HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
sb/amd/*/*/smbus.h: Make 'smbus.h' uniform
Reformat 'smbus.h' files and add missing <stdint.h>.
Change-Id: If78f483ca8ad2e3cffe60e22948dc8150cce3664 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/smbus.h M src/southbridge/amd/cimx/sb800/smbus.h M src/southbridge/amd/pi/hudson/smbus.h 3 files changed, 44 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45892/1
diff --git a/src/southbridge/amd/agesa/hudson/smbus.h b/src/southbridge/amd/agesa/hudson/smbus.h index 6381d97..96ff574 100644 --- a/src/southbridge/amd/agesa/hudson/smbus.h +++ b/src/southbridge/amd/agesa/hudson/smbus.h @@ -5,29 +5,29 @@
#include <stdint.h>
-#define SMBHSTSTAT 0x0 -#define SMBSLVSTAT 0x1 -#define SMBHSTCTRL 0x2 -#define SMBHSTCMD 0x3 -#define SMBHSTADDR 0x4 -#define SMBHSTDAT0 0x5 -#define SMBHSTDAT1 0x6 -#define SMBHSTBLKDAT 0x7 +#define SMBHSTSTAT 0x0 +#define SMBSLVSTAT 0x1 +#define SMBHSTCTRL 0x2 +#define SMBHSTCMD 0x3 +#define SMBHSTADDR 0x4 +#define SMBHSTDAT0 0x5 +#define SMBHSTDAT1 0x6 +#define SMBHSTBLKDAT 0x7
-#define SMBSLVCTRL 0x8 -#define SMBSLVCMD_SHADOW 0x9 -#define SMBSLVEVT 0xa -#define SMBSLVDAT 0xc +#define SMBSLVCTRL 0x8 +#define SMBSLVCMD_SHADOW 0x9 +#define SMBSLVEVT 0xa +#define SMBSLVDAT 0xc
-#define AX_INDXC 0 -#define AX_INDXP 2 -#define AXCFG 4 -#define ABCFG 6 -#define RC_INDXC 1 -#define RC_INDXP 3 +#define AX_INDXC 0 +#define AX_INDXP 2 +#define AXCFG 4 +#define ABCFG 6 +#define RC_INDXC 1 +#define RC_INDXP 3
-#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/southbridge/amd/cimx/sb800/smbus.h b/src/southbridge/amd/cimx/sb800/smbus.h index 0a1b279..8db8d62 100644 --- a/src/southbridge/amd/cimx/sb800/smbus.h +++ b/src/southbridge/amd/cimx/sb800/smbus.h @@ -3,33 +3,33 @@ #ifndef _SB800_SMBUS_H_ #define _SB800_SMBUS_H_
+#include <stdint.h> + #define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS
-#define SMBHSTSTAT 0x0 -#define SMBSLVSTAT 0x1 -#define SMBHSTCTRL 0x2 -#define SMBHSTCMD 0x3 -#define SMBHSTADDR 0x4 -#define SMBHSTDAT0 0x5 -#define SMBHSTDAT1 0x6 -#define SMBHSTBLKDAT 0x7 +#define SMBHSTSTAT 0x0 +#define SMBSLVSTAT 0x1 +#define SMBHSTCTRL 0x2 +#define SMBHSTCMD 0x3 +#define SMBHSTADDR 0x4 +#define SMBHSTDAT0 0x5 +#define SMBHSTDAT1 0x6 +#define SMBHSTBLKDAT 0x7
-#define SMBSLVCTRL 0x8 -#define SMBSLVCMD_SHADOW 0x9 -#define SMBSLVEVT 0xa -#define SMBSLVDAT 0xc +#define SMBSLVCTRL 0x8 +#define SMBSLVCMD_SHADOW 0x9 +#define SMBSLVEVT 0xa +#define SMBSLVDAT 0xc
-/*//SB00.H -#define AX_INDXC 0 -#define AX_INDXP 2 -#define AXCFG 4 -#define ABCFG 6 -#define RC_INDXC 1 -#define RC_INDXP 3 -*/ +#define AX_INDXC 0 +#define AX_INDXP 2 +#define AXCFG 4 +#define ABCFG 6 +#define RC_INDXC 1 +#define RC_INDXP 3
-#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/southbridge/amd/pi/hudson/smbus.h b/src/southbridge/amd/pi/hudson/smbus.h index 2398910..96ff574 100644 --- a/src/southbridge/amd/pi/hudson/smbus.h +++ b/src/southbridge/amd/pi/hudson/smbus.h @@ -26,8 +26,8 @@ #define RC_INDXC 1 #define RC_INDXP 3
-#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/smbus.h:
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... PS1, Line 25: #define AX_INDXP 2 AX_INDXP is 1 or 2 ?
"In file included from src/southbridge/amd/cimx/sb800/late.c:23: src/southbridge/amd/cimx/sb800/smbus.h:25: error: "AX_INDXP" redefined [-Werror] #define AX_INDXP 2
In file included from src/southbridge/amd/cimx/sb800/SBPLATFORM.h:41, from src/southbridge/amd/cimx/sb800/late.c:19: src/vendorcode/amd/cimx/sb800/SB800.h:709: note: this is the location of the previous definition #define AX_INDXP 1"
Hello build bot (Jenkins), Marc Jones,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45892
to look at the new patch set (#3).
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
sb/amd/*/*/smbus.h: Make 'smbus.h' uniform
Reformat 'smbus.h' files and add missing <stdint.h>.
Change-Id: If78f483ca8ad2e3cffe60e22948dc8150cce3664 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/smbus.h M src/southbridge/amd/cimx/sb800/smbus.h M src/southbridge/amd/pi/hudson/smbus.h 3 files changed, 38 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45892/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... File src/southbridge/amd/cimx/sb800/smbus.h:
https://review.coreboot.org/c/coreboot/+/45892/1/src/southbridge/amd/cimx/sb... PS1, Line 25: #define AX_INDXP 2
AX_INDXP is 1 or 2 ? […]
Done
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45892 )
Change subject: sb/amd/*/*/smbus.h: Make 'smbus.h' uniform ......................................................................
sb/amd/*/*/smbus.h: Make 'smbus.h' uniform
Reformat 'smbus.h' files and add missing <stdint.h>.
Change-Id: If78f483ca8ad2e3cffe60e22948dc8150cce3664 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45892 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marc Jones marc@marcjonesconsulting.com --- M src/southbridge/amd/agesa/hudson/smbus.h M src/southbridge/amd/cimx/sb800/smbus.h M src/southbridge/amd/pi/hudson/smbus.h 3 files changed, 38 insertions(+), 45 deletions(-)
Approvals: build bot (Jenkins): Verified Marc Jones: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/smbus.h b/src/southbridge/amd/agesa/hudson/smbus.h index 6381d97..96ff574 100644 --- a/src/southbridge/amd/agesa/hudson/smbus.h +++ b/src/southbridge/amd/agesa/hudson/smbus.h @@ -5,29 +5,29 @@
#include <stdint.h>
-#define SMBHSTSTAT 0x0 -#define SMBSLVSTAT 0x1 -#define SMBHSTCTRL 0x2 -#define SMBHSTCMD 0x3 -#define SMBHSTADDR 0x4 -#define SMBHSTDAT0 0x5 -#define SMBHSTDAT1 0x6 -#define SMBHSTBLKDAT 0x7 +#define SMBHSTSTAT 0x0 +#define SMBSLVSTAT 0x1 +#define SMBHSTCTRL 0x2 +#define SMBHSTCMD 0x3 +#define SMBHSTADDR 0x4 +#define SMBHSTDAT0 0x5 +#define SMBHSTDAT1 0x6 +#define SMBHSTBLKDAT 0x7
-#define SMBSLVCTRL 0x8 -#define SMBSLVCMD_SHADOW 0x9 -#define SMBSLVEVT 0xa -#define SMBSLVDAT 0xc +#define SMBSLVCTRL 0x8 +#define SMBSLVCMD_SHADOW 0x9 +#define SMBSLVEVT 0xa +#define SMBSLVDAT 0xc
-#define AX_INDXC 0 -#define AX_INDXP 2 -#define AXCFG 4 -#define ABCFG 6 -#define RC_INDXC 1 -#define RC_INDXP 3 +#define AX_INDXC 0 +#define AX_INDXP 2 +#define AXCFG 4 +#define ABCFG 6 +#define RC_INDXC 1 +#define RC_INDXP 3
-#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/southbridge/amd/cimx/sb800/smbus.h b/src/southbridge/amd/cimx/sb800/smbus.h index 0a1b279..d058bc8 100644 --- a/src/southbridge/amd/cimx/sb800/smbus.h +++ b/src/southbridge/amd/cimx/sb800/smbus.h @@ -3,33 +3,26 @@ #ifndef _SB800_SMBUS_H_ #define _SB800_SMBUS_H_
+#include <stdint.h> + #define SMBUS_IO_BASE SMBUS0_BASE_ADDRESS
-#define SMBHSTSTAT 0x0 -#define SMBSLVSTAT 0x1 -#define SMBHSTCTRL 0x2 -#define SMBHSTCMD 0x3 -#define SMBHSTADDR 0x4 -#define SMBHSTDAT0 0x5 -#define SMBHSTDAT1 0x6 -#define SMBHSTBLKDAT 0x7 +#define SMBHSTSTAT 0x0 +#define SMBSLVSTAT 0x1 +#define SMBHSTCTRL 0x2 +#define SMBHSTCMD 0x3 +#define SMBHSTADDR 0x4 +#define SMBHSTDAT0 0x5 +#define SMBHSTDAT1 0x6 +#define SMBHSTBLKDAT 0x7
-#define SMBSLVCTRL 0x8 -#define SMBSLVCMD_SHADOW 0x9 -#define SMBSLVEVT 0xa -#define SMBSLVDAT 0xc +#define SMBSLVCTRL 0x8 +#define SMBSLVCMD_SHADOW 0x9 +#define SMBSLVEVT 0xa +#define SMBSLVDAT 0xc
-/*//SB00.H -#define AX_INDXC 0 -#define AX_INDXP 2 -#define AXCFG 4 -#define ABCFG 6 -#define RC_INDXC 1 -#define RC_INDXP 3 -*/ - -#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs. diff --git a/src/southbridge/amd/pi/hudson/smbus.h b/src/southbridge/amd/pi/hudson/smbus.h index 2398910..96ff574 100644 --- a/src/southbridge/amd/pi/hudson/smbus.h +++ b/src/southbridge/amd/pi/hudson/smbus.h @@ -26,8 +26,8 @@ #define RC_INDXC 1 #define RC_INDXP 3
-#define AB_INDX 0xCD8 -#define AB_DATA (AB_INDX+4) +#define AB_INDX 0xcd8 +#define AB_DATA (AB_INDX + 4)
/* Between 1-10 seconds, We should never timeout normally * Longer than this is just painful when a timeout condition occurs.
-
HAOUAS Elyes (Code Review) -
Marc Jones (Code Review)
-
Patrick Georgi (Code Review)