Attention is currently required from: Kevin Chiu, Paul Menzel, Eric Peers, Rob Barnes, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57263 )
Change subject: mb/google/guybrush/nipperkin: update nipperkin config
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/57263/comment/63dfb75d_f022c44b
PS2, Line 131: chip drivers/i2c/generic
: register "hid" = ""10EC1019""
: register "desc" = ""Realtek SPK AMP L""
: register "uid" = "0"
: register "probed" = "1"
: device i2c 28 on end
: end
: chip drivers/i2c/generic
: register "hid" = ""10EC1019""
: register "desc" = ""Realtek SPK AMP R""
: register "uid" = "1"
: device i2c 29 on end
: end
Learnt through this bug: https://b.corp.google.com/issues/194916917#comment26, that Nipperkin is going to use MAX98360A.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58a9b8393a965a9c793802d3e660829863b74375
Gerrit-Change-Number: 57263
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 04 Sep 2021 05:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment