Change in coreboot[master]: commonlib/storage: remove static from mmc speed change functions
Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45984 )
Change subject: commonlib/storage: remove static from mmc speed change functions ......................................................................
commonlib/storage: remove static from mmc speed change functions
Remove static from few mmc speed change functions so that they can be called by emmc dll tuning code.
BUG=b:140124451 TEST=Boot to OS via emmc
Signed-off-by: Bora Guvendik bora.guvendik@intel.com Change-Id: If61345efb78a19dcaa2bcfe253dfe0ac4104bd10 --- M src/commonlib/include/commonlib/storage.h M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.h 3 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45984/1
diff --git a/src/commonlib/include/commonlib/storage.h b/src/commonlib/include/commonlib/storage.h index a00b962..44e39fd 100644 --- a/src/commonlib/include/commonlib/storage.h +++ b/src/commonlib/include/commonlib/storage.h @@ -4,6 +4,7 @@ #define __COMMONLIB_STORAGE_H__
#include <commonlib/sd_mmc_ctrlr.h> +#include <stddef.h>
/* * EXT_CSD fields @@ -132,4 +133,11 @@
void storage_display_setup(struct storage_media *media);
+int sd_mmc_send_status(struct storage_media *media, ssize_t tries); +int mmc_select_hs(struct storage_media *media); +int mmc_select_ds(struct storage_media *media, int csd_timing_override); +int mmc_select_ddr50(struct storage_media *media); +int mmc_select_hs200(struct storage_media *media); +int mmc_select_hs400(struct storage_media *media); + #endif /* __COMMONLIB_STORAGE_H__ */ diff --git a/src/commonlib/storage/mmc.c b/src/commonlib/storage/mmc.c index a2bd067..2a4cb2b 100644 --- a/src/commonlib/storage/mmc.c +++ b/src/commonlib/storage/mmc.c @@ -161,7 +161,7 @@ SET_CLOCK(media->ctrlr, clock); }
-static int mmc_select_hs(struct storage_media *media) +int mmc_select_hs(struct storage_media *media) { int ret;
@@ -182,7 +182,7 @@ return ret; }
-static int mmc_select_ddr50(struct storage_media *media) +int mmc_select_ddr50(struct storage_media *media) { int ret;
@@ -209,7 +209,7 @@ return ret; }
-static int mmc_select_ds(struct storage_media *media, int csd_timing_override) +int mmc_select_ds(struct storage_media *media, int csd_timing_override) { int ret;
@@ -279,7 +279,7 @@ return -1; }
-static int mmc_select_hs400(struct storage_media *media) +int mmc_select_hs400(struct storage_media *media) { uint8_t bus_width; uint32_t caps; @@ -328,7 +328,7 @@ return ret; }
-static int mmc_select_hs200(struct storage_media *media) +int mmc_select_hs200(struct storage_media *media) { struct sd_mmc_ctrlr *ctrlr = media->ctrlr; int ret; diff --git a/src/commonlib/storage/sd_mmc.h b/src/commonlib/storage/sd_mmc.h index 9f6c077..2a3ea18 100644 --- a/src/commonlib/storage/sd_mmc.h +++ b/src/commonlib/storage/sd_mmc.h @@ -5,7 +5,6 @@
#include <commonlib/sd_mmc_ctrlr.h> #include <commonlib/storage.h> -#include <stddef.h> #include <console/console.h>
#define SD_MMC_IO_RETRIES 1000 @@ -35,7 +34,6 @@ uint64_t sd_mmc_extract_uint32_bits(const uint32_t *array, int start, int count); int sd_mmc_go_idle(struct storage_media *media); -int sd_mmc_send_status(struct storage_media *media, ssize_t tries); int sd_mmc_set_blocklen(struct sd_mmc_ctrlr *ctrlr, int len);
/* MMC support routines */
Hello build bot (Jenkins), Selma Bensaid, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45984
to look at the new patch set (#2).
Change subject: commonlib/storage: remove static from mmc speed change functions ......................................................................
commonlib/storage: remove static from mmc speed change functions
Remove static from few mmc speed change functions so that they can be called by emmc dll tuning code.
BUG=b:140124451 TEST=Boot to OS via emmc
Signed-off-by: Bora Guvendik bora.guvendik@intel.com Change-Id: If61345efb78a19dcaa2bcfe253dfe0ac4104bd10 --- M src/commonlib/include/commonlib/storage.h M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.h 3 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45984/2
Hello build bot (Jenkins), Selma Bensaid, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45984
to look at the new patch set (#3).
Change subject: commonlib/storage: remove static from mmc speed change functions ......................................................................
commonlib/storage: remove static from mmc speed change functions
Remove static from few mmc speed change functions so that they can be called by emmc dll tuning code.
BUG=b:140124451 TEST=Boot to OS via emmc
Signed-off-by: Bora Guvendik bora.guvendik@intel.com Change-Id: If61345efb78a19dcaa2bcfe253dfe0ac4104bd10 --- M src/commonlib/include/commonlib/storage.h M src/commonlib/storage/mmc.c M src/commonlib/storage/sd_mmc.h 3 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45984/3
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45984?usp=email )
Change subject: commonlib/storage: remove static from mmc speed change functions ......................................................................
Abandoned
-
Bora Guvendik (Code Review) -
Stefan Reinauer (Code Review)