Attention is currently required from: Jason Glenesk, Marshall Dawson, Zheng Bao, Felix Held. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/50117
to review the following change.
Change subject: mb/amd/majolica: Add an empty bootblock function to handle GPIO ......................................................................
mb/amd/majolica: Add an empty bootblock function to handle GPIO
Change-Id: I35da3812a424ea1beef86d043a756a87e6afdaa3 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/amd/majolica/bootblock.c A src/mainboard/amd/majolica/early_gpio.c A src/mainboard/amd/majolica/gpio.h 3 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/50117/1
diff --git a/src/mainboard/amd/majolica/bootblock.c b/src/mainboard/amd/majolica/bootblock.c index ccd8ec1..f768f3f 100644 --- a/src/mainboard/amd/majolica/bootblock.c +++ b/src/mainboard/amd/majolica/bootblock.c @@ -1,7 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> +#include "gpio.h"
void bootblock_mainboard_early_init(void) { + mainboard_program_early_gpios(); } diff --git a/src/mainboard/amd/majolica/early_gpio.c b/src/mainboard/amd/majolica/early_gpio.c new file mode 100644 index 0000000..916d679 --- /dev/null +++ b/src/mainboard/amd/majolica/early_gpio.c @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/gpio.h> +#include "gpio.h" + +/* GPIO pins used by coreboot should be initialized in bootblock */ + +static const struct soc_amd_gpio gpio_set_stage_reset[] = { +}; + +void mainboard_program_early_gpios(void) +{ + program_gpios(gpio_set_stage_reset, ARRAY_SIZE(gpio_set_stage_reset)); +} diff --git a/src/mainboard/amd/majolica/gpio.h b/src/mainboard/amd/majolica/gpio.h new file mode 100644 index 0000000..2143368 --- /dev/null +++ b/src/mainboard/amd/majolica/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef MAINBOARD_GPIO_H +#define MAINBOARD_GPIO_H + +void mainboard_program_early_gpios(void); /* bootblock GPIO configuration */ + +#endif /* MAINBOARD_GPIO_H */