Attention is currently required from: Bora Guvendik, Cliff Huang, Intel coreboot Reviewers, Jérémy Compostella, Kyoung Il Kim, Subrata Banik.
Paul Menzel has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85198?usp=email )
Change subject: drivers/intel/touch: Add Intel Touch Controller driver ......................................................................
Patch Set 12:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85198/comment/3639e1a3_d29d7f07?usp... : PS12, Line 26: Does the driver log something? Any hints how to debug the driver?
File src/drivers/intel/touch/chip.h:
https://review.coreboot.org/c/coreboot/+/85198/comment/237027dc_e0a3cce3?usp... : PS12, Line 15: uint64_t connection_speed; What is the unit?
https://review.coreboot.org/c/coreboot/+/85198/comment/ac0400ea_566e83d1?usp... : PS12, Line 18: Period What is the unit?
https://review.coreboot.org/c/coreboot/+/85198/comment/6f566e3f_dba70fe0?usp... : PS12, Line 183: /* Delay to be inserted after device is taken out of reset. */ No dot at the end (also above and below).
File src/drivers/intel/touch/elan.h:
https://review.coreboot.org/c/coreboot/+/85198/comment/4d454ef3_37114114?usp... : PS12, Line 17: #define ELAN_RST_SEQ_DLY 300 Please add the unit to the name.
https://review.coreboot.org/c/coreboot/+/85198/comment/d8d7beba_2d5df427?usp... : PS12, Line 45: 2C Fast Missing I?