Change in coreboot[master]: payloads/ext/tianocore/Makefile: Enable quiet mode

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

payloads/ext/tianocore/Makefile: Enable quiet mode

The build process of this payload is unnecessarily prolix. Therefore,
make use of the `-u` flag to abridge the output.

Tested by building for X64, UEFIPAYLOAD.fd does not differ.

Change-Id: I6eba069ff5be2813d180dae40ab10155f0542f33
Signed-off-by: Angel Pons 
---
M payloads/external/tianocore/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/39123/1

diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile
index 7adb700..3fc9ce5 100644
--- a/payloads/external/tianocore/Makefile
+++ b/payloads/external/tianocore/Makefile
@@ -49,9 +49,9 @@
 endif

ifeq ($(CONFIG_TIANOCORE_TARGET_IA32), y)
-	BUILD_STR=-a IA32 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
+	BUILD_STR=-a IA32 -q -t COREBOOT -p $(bootloader)/$(bootloader)Ia32.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
 else
-	BUILD_STR=-a IA32 -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
+	BUILD_STR=-a IA32 -q -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
 endif

all: clean build

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 1: Code-Review+2

tested, does what it says

[Benjamin Doron (Code Review)]

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39123/1/payloads/external/tianocore... 
File payloads/external/tianocore/Makefile:

https://review.coreboot.org/c/coreboot/+/39123/1/payloads/external/tianocore... 
PS1, Line 54: 	BUILD_STR=-a IA32 -q -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
Maybe use "-a IA32 -a X64 -q"
It could be easier to read the arguments.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39123/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39123/1//COMMIT_MSG@10 
PS1, Line 10: -u
-q is used in the diff.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39123/1/payloads/external/tianocore... 
File payloads/external/tianocore/Makefile:

https://review.coreboot.org/c/coreboot/+/39123/1/payloads/external/tianocore... 
PS1, Line 54: 	BUILD_STR=-a IA32 -q -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
> Maybe use "-a IA32 -a X64 -q" […]

I get what you mean. I think it's better to factor out the common part of BUILD_STR anyway.

I'll put `-q` at the beginning, so that it appears in the same column on both lines.

[Angel Pons (Code Review)]

Hello Benjamin Doron, Matt DeVillier, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39123

to look at the new patch set (#2).

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

payloads/ext/tianocore/Makefile: Enable quiet mode

The build process of this payload is unnecessarily prolix. Therefore,
make use of the `-u` flag to abridge the output.

Tested by building for X64, UEFIPAYLOAD.fd does not differ.

Change-Id: I6eba069ff5be2813d180dae40ab10155f0542f33
Signed-off-by: Angel Pons 
---
M payloads/external/tianocore/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/39123/2

[Angel Pons (Code Review)]

Hello Benjamin Doron, Matt DeVillier, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39123

to look at the new patch set (#3).

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

payloads/ext/tianocore/Makefile: Enable quiet mode

The build process of this payload is unnecessarily prolix. Therefore,
make use of the `-q` flag to abridge the output.

TEST=When building for X64, UEFIPAYLOAD.fd does not differ.

Change-Id: I6eba069ff5be2813d180dae40ab10155f0542f33
Signed-off-by: Angel Pons 
---
M payloads/external/tianocore/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/39123/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39123/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39123/1//COMMIT_MSG@10 
PS1, Line 10: -u
> -q is used in the diff.

D'oh! I must have been drunk, probably due to an overdose of UEFI...

In any case, done.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 3: Code-Review+1

[Benjamin Doron (Code Review)]

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 3: Code-Review+1

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 3: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

payloads/ext/tianocore/Makefile: Enable quiet mode

The build process of this payload is unnecessarily prolix. Therefore,
make use of the `-q` flag to abridge the output.

TEST=When building for X64, UEFIPAYLOAD.fd does not differ.

Change-Id: I6eba069ff5be2813d180dae40ab10155f0542f33
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39123
Reviewed-by: Paul Menzel 
Reviewed-by: Benjamin Doron 
Reviewed-by: Matt DeVillier 
Tested-by: build bot (Jenkins) 
---
M payloads/external/tianocore/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Matt DeVillier: Looks good to me, approved
  Benjamin Doron: Looks good to me, but someone else must approve

diff --git a/payloads/external/tianocore/Makefile b/payloads/external/tianocore/Makefile
index 7adb700..af06464 100644
--- a/payloads/external/tianocore/Makefile
+++ b/payloads/external/tianocore/Makefile
@@ -49,9 +49,9 @@
 endif

ifeq ($(CONFIG_TIANOCORE_TARGET_IA32), y)
-	BUILD_STR=-a IA32 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
+	BUILD_STR=-q -a IA32 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
 else
-	BUILD_STR=-a IA32 -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
+	BUILD_STR=-q -a IA32 -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(build_flavor)
 endif

all: clean build

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39123 )

Change subject: payloads/ext/tianocore/Makefile: Enable quiet mode
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/951
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/950
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/949

Please note: This test is under development and might not be accurate at all!