Attention is currently required from: Felix Singer.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75078?usp=email )
Change subject: mb/siemens: Move selects from Kconfig.name to Kconfig ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/mainboard/siemens/mc_apl1/Kconfig:
https://review.coreboot.org/c/coreboot/+/75078/comment/d579ae42_b3b8f3f7 : PS5, Line 10: config BOARD_SIEMENS_MC_APL1 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL2 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL3 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL4 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL5 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL6 : select BOARD_SIEMENS_BASEBOARD_MC_APL1 : : config BOARD_SIEMENS_MC_APL7 : select BOARD_SIEMENS_BASEBOARD_MC_APL1
Isn't it then perhaps better to select _BASEBOARD_ in variant/.. […]
We can also move this later on variant level, or leave it here.