Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel, Sathya Prakash M R, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54716 )
Change subject: mb/google/brya: Add firmware configuration probing for audio
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/54716/comment/96a8a995_d4a10599
PS7, Line 82: BS_PRE_DEVICE
I have changed it to BS_DEV_ENABLE for now, PRE_DEVICE changes can be discussed on the corresponding […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54716
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f159442516830f9d304d78c83f070e4fcff4a37
Gerrit-Change-Number: 54716
Gerrit-PatchSet: 8
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:15:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment