Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19752 )
Change subject: amd/gardenia: Init cbmem in romstage ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19752/2/src/mainboard/amd/gardenia/romstage.... File src/mainboard/amd/gardenia/romstage.c:
Line 67: cbmem_initialize_empty();
This should be in the SoC code. Really, this entire sequence is needs to be
I agree. This all moves in the "Convert to C_ENVIRONMENT_BOOTBLOCK" patch https://review.coreboot.org/#/c/19755. It felt like 6 vs. 0.5 dozen on which to do first. Doing it this way allowed me to easily verify the other was working as expected.