build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56420 )
Change subject: mb/google/brya/variants/primus: Update two GPIOs
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/brya/variants/primus/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124610):
https://review.coreboot.org/c/coreboot/+/56420/comment/54ec654c_646ccc57
PS5, Line 51: /* E21 : USB_C1_LSX_SOC_RX_STRAP ==> NC */
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124610):
https://review.coreboot.org/c/coreboot/+/56420/comment/e7f07d5b_edc02034
PS5, Line 52: PAD_NC(GPP_E21, NONE),
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124610):
https://review.coreboot.org/c/coreboot/+/56420/comment/f6431c35_e01ee4a2
PS5, Line 52: PAD_NC(GPP_E21, NONE),
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3c60adeb5d35c79a1c700937f93a80ad3587c5e
Gerrit-Change-Number: 56420
Gerrit-PatchSet: 5
Gerrit-Owner: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Jarvis Shih
jarvis_shih@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 20 Jul 2021 06:08:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment