Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32349
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
mb/google/octopus/variants/bloog: Disable unused I2C1
I2C1 is unused, so disable it.
BUG=none BRANCH=octopus TEST=Verify reboot and s0ix suspend successfully
Change-Id: I7ed5065cfd0b9780d13feb27cc78b8090d7a03a6 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32349/1
diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb index 20b5dd3..5f7605f 100644 --- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb @@ -59,6 +59,7 @@
device domain 0 on device pci 16.0 off end # - I2C 0 + device pci 16.1 off end # - I2C 1 device pci 17.1 on chip drivers/i2c/da7219 register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_137_IRQ)"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32349/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/32349/2/src/mainboard/google/octopus/variant... PS2, Line 62: device pci 16.1 off end # - I2C 1 I don't see I2C 1 being used in any of the octopus variants. Probably it is a better idea to disable it in the baseboard devicetree itself.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
Hi Karthik, I'm not sure if any future projects may use it. Should I disable it in baseboard instead? Thanks
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
(1 comment)
Hi Karthik, I'm not sure if any future projects may use it. Should I disable it in baseboard instead? Thanks
We can always enable it in the concerned variant's overridetree if any future projects use it.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1 ......................................................................
Patch Set 2:
Since change in the baseboard affects all the other existing projects, could we let this change land in bloog first? Thanks
Hello Karthik Ramasubramanian, Wisley Chen, Justin TerAvest, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32349
to look at the new patch set (#3).
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
mb/google/octopus/variants/baseboard: Disable unused I2C 1
I2C 1 is not being used in any of the octopus variants, so disable it.
BUG=none BRANCH=octopus TEST=Verify on meep and bloog reboot and s0ix suspend successfully
Change-Id: I7ed5065cfd0b9780d13feb27cc78b8090d7a03a6 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32349/3
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3:
Move change to disable I2C 1 in the baseboard devicetree.
Hi reviewer, please help review again. Thanks
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
Done.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3: Code-Review+2
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3:
Hi googler, Can you help merge this change and cherry-pick it to master branch? Thank you
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 3:
Patch Set 3:
Hi googler, Can you help merge this change and cherry-pick it to master branch? Thank you
I mean cherry-pick to chromium master branch. Thanks
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
mb/google/octopus/variants/baseboard: Disable unused I2C 1
I2C 1 is not being used in any of the octopus variants, so disable it.
BUG=none BRANCH=octopus TEST=Verify on meep and bloog reboot and s0ix suspend successfully
Change-Id: I7ed5065cfd0b9780d13feb27cc78b8090d7a03a6 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32349 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index e134aa2..fc609cd 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -165,7 +165,7 @@ end # - XHCI device pci 15.1 on end # - XDCI device pci 16.0 on end # - I2C 0 - device pci 16.1 on end # - I2C 1 + device pci 16.1 off end # - I2C 1 device pci 16.2 off end # - I2C 2 device pci 16.3 off end # - I2C 3 device pci 17.0 on end # - I2C 4
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 4:
Hi Furquan, Could you help cherry-pick it into chromium master branch? Thank you
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 4:
Hi Martin and Patrick, This change is not show in the chromium master branch, yet. Could you help checking it? Thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 4:
Patch Set 4:
Hi Martin and Patrick, This change is not show in the chromium master branch, yet. Could you help checking it? Thanks
Karthik was planning on helping with this.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/baseboard: Disable unused I2C 1 ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
Hi Martin and Patrick, This change is not show in the chromium master branch, yet. Could you help checking it? Thanks
Karthik was planning on helping with this.
The change has been cherry-picked into chromium master branch this morning by Patrick.
-
Furquan Shaikh (Code Review) -
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Menzel (Code Review)
-
Tony Huang (Code Review)