Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )
Change subject: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 2:
(7 comments)
File src/soc/qualcomm/sc7280/carve_out.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/abc2657c_b2e9b355 PS2, Line 15: printk(BIOS_DEBUG, " RAVI: %s : START : %p\n",__func__, _dram_modem); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/974ca700_e7afa4c4 PS2, Line 16: printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/0050cecf_d57b8d4c PS2, Line 16: printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/850462ab_1ce6997a PS2, Line 16: printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem); space required after that ',' (ctx:VxV)
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/90342c0f_5ec8159d PS2, Line 27: if (soc_modem_carve_out(&start, &end)) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/31d6f3db_538f97e7 PS2, Line 29: printk(BIOS_DEBUG, " RAVI: %s : START : %p\n",__func__, start); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131359): https://review.coreboot.org/c/coreboot/+/58545/comment/11c72765_e646ab0b PS2, Line 30: printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, end); space required after that ',' (ctx:VxV)