Attention is currently required from: Pranava Y N, Tongtong Pan.
Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/85965?usp=email )
Change subject: mb/google/fatcat/var/felino: Modify the felino config for probing TPM I2C
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/fatcat/variants/felino/gpio.c:
https://review.coreboot.org/c/coreboot/+/85965/comment/7afdec1c_f2400f0d?usp... :
PS1, Line 415: PAD_CFG_NF(GPP_C04, NONE, DEEP, NF1),
:
: /* GPP_H21: PCH_I2C_GSC_SDA */
: PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1),
: /* GPP_H22: PCH_I2C_GSC_SCL */
: PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1),
: /* GPP_F15: SPI_TPM_INT_N */
: PAD_CFG_GPI_APIC_LOCK(GPP_F15, NONE, LEVEL, INVERT, LOCK_CONFIG),
I don't think it's necessary to add these in romstage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85965?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I093c0bad181f133e601f3270de68c0848f847ccf
Gerrit-Change-Number: 85965
Gerrit-PatchSet: 1
Gerrit-Owner: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 03:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No