Change in coreboot[master]: guybrush/variants/baseboard/devicetree.cb - coreboot-gerrit

5 Sep 2021


      Attention is currently required from: Angel Pons, Name of user not set #1003801, Julian Schroeder.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57215 )
Change subject: guybrush/variants/baseboard/devicetree.cb
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
...
Why are these IDs not programmed in SoC code?
yeah, since that's needed for every mainboard that has usb_phy_custom set to 1, we should set those values in the soc code instead to not have to specify those same constants in every mainboard
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57215
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4fdb5af1cbc3c70cc113ef6f0fd9332e1a27f142
Gerrit-Change-Number: 57215
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Julian Schroeder julianmarcusschroeder@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Name of user not set #1003801
Gerrit-Attention: Julian Schroeder julianmarcusschroeder@gmail.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 20:20:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment