Attention is currently required from: Christopher Meis, Patrick Rudolph, Arthur Heymans. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55513 )
Change subject: intel/fit - Prepare for BootGuard support ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: confi
File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/55513/comment/ce6015b1_d54f609d PS1, Line 16: intel_fit-position := 0xffff0000 # Set position for BootGuard
#557867 states that those modules "are expected to be" at those location. That's not *must be* IMHO. […]
I can confirm KBL had the top 4MB restriction for those blobs. If any of the components was out of the range, it just didn't boot with the profile 5.
BTW: why don't you reuse what I already sent for review earlier? https://review.coreboot.org/q/topic:%22intel_bootguard%22+(status:open%20OR%...) I clearly see you duplicate some of the work done there.
-
Michał Żygowski (Code Review)