Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49170 )
Change subject: sb/intel/bd82x6x: Use `PCH_LPC_DEV` macro ......................................................................
sb/intel/bd82x6x: Use `PCH_LPC_DEV` macro
Change-Id: I681bb126546b5a7bda3f1bac05c345d2cf60b178 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/bd82x6x/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/49170/1
diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c index f82c5ee..916cc1a 100644 --- a/src/southbridge/intel/bd82x6x/smihandler.c +++ b/src/southbridge/intel/bd82x6x/smihandler.c @@ -70,7 +70,7 @@ { u16 gpiobase;
- gpiobase = pci_read_config16(PCI_DEV(0, 0x1f, 0), GPIOBASE) & 0xfffc; + gpiobase = pci_read_config16(PCH_LPC_DEV, GPIOBASE) & 0xfffc; if (!gpiobase) return;
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49170 )
Change subject: sb/intel/bd82x6x: Use `PCH_LPC_DEV` macro ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49170 )
Change subject: sb/intel/bd82x6x: Use `PCH_LPC_DEV` macro ......................................................................
sb/intel/bd82x6x: Use `PCH_LPC_DEV` macro
Change-Id: I681bb126546b5a7bda3f1bac05c345d2cf60b178 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49170 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/southbridge/intel/bd82x6x/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c index 1a9e5b4..f0929f4 100644 --- a/src/southbridge/intel/bd82x6x/smihandler.c +++ b/src/southbridge/intel/bd82x6x/smihandler.c @@ -70,7 +70,7 @@ { u16 gpiobase;
- gpiobase = pci_read_config16(PCI_DEV(0, 0x1f, 0), GPIOBASE) & 0xfffc; + gpiobase = pci_read_config16(PCH_LPC_DEV, GPIOBASE) & 0xfffc; if (!gpiobase) return;
-
Angel Pons (Code Review) -
Felix Singer (Code Review)