Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86013?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in ramstage ......................................................................
Patch Set 1:
(8 comments)
Patchset:
PS1: dd a
Commit Message:
https://review.coreboot.org/c/coreboot/+/86013/comment/c39e5b9d_b6886014?usp... : PS1, Line 9: is a new blob that include `contains blobs that include` (because we have 2 blobs)
https://review.coreboot.org/c/coreboot/+/86013/comment/5010b48c_9c64ea1d?usp... : PS1, Line 15: Add support for running the ramstage blob mtk_fsp_ramstage.elf, which will run at address 0x90000000.
File src/soc/mediatek/common/include/soc/memlayout.h:
https://review.coreboot.org/c/coreboot/+/86013/comment/250436da_0da6433d?usp... : PS1, Line 24: #define FSP_INIT_CODE(addr, size) \ Move below `DRAM_INIT_CODE`.
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86013/comment/c1bdc12c_4b9b5ba0?usp... : PS1, Line 99: FSP_CBFS `FSP_RAMSTAGE_CBFS`
https://review.coreboot.org/c/coreboot/+/86013/comment/d4be6413_6415a03c?usp... : PS1, Line 104: No indentation.
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/86013/comment/390844d3_6ca4b7fc?usp... : PS1, Line 38: ufs_storage_type storage_type
https://review.coreboot.org/c/coreboot/+/86013/comment/f4f39d27_dfda3c41?usp... : PS1, Line 41: mtk_fsp_load_and_run(); add a blank line below