Attention is currently required from: Furquan Shaikh, Martin Roth, Jonathan Zhang, Paul Menzel, Angel Pons, Arthur Heymans.
Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51180 )
Change subject: util/sconfig: Fix for multidomain support sconfig/devicetree.cb
......................................................................
Patch Set 5:
(1 comment)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/51180/comment/67ea42ca_83805597
PS5, Line 1344: extern DEVTREE_CONST struct device *const __pci_%d_%02x_%d
We need something that will distinguish devices on different domains - so why not use domain numbe […]
Without that it's still there in the linked list and you can appropriately find and use it.
Finally it is not there because we have compilation error due to more than one variable declaration with exactly same name. It`s to avoid compilation error in case described in commit message.
If you don't know the real bus (eg in early stages) and have not set it there is no point in trying the access this device, so also no point to try to expose it conveniently.
I don`t know bus number but I know that it is root bus in domain x so I can reference it as __pci_x_0_0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd639d0cb3ed1a49ed7c7b1c77ac747ba6f77672
Gerrit-Change-Number: 51180
Gerrit-PatchSet: 5
Gerrit-Owner: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 31 Mar 2022 23:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mariusz Szafrański
mariuszx.szafranski@intel.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment