John Looney has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32144
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Add default boards for qemu, that has VPD partitions.
Tested with https://review.coreboot.org/c/coreboot/+/31984 and the 'vpd' command to add VPD variables to those partitions, then checked that they were exported to userspace.
Change-Id: I2aca55543cb3bdbdb77c8b421cbbafad2405d3cc --- A src/mainboard/emulation/qemu-i440fx/board.fmd A src/mainboard/emulation/qemu-q35/board.fmd 2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/32144/1
diff --git a/src/mainboard/emulation/qemu-i440fx/board.fmd b/src/mainboard/emulation/qemu-i440fx/board.fmd new file mode 100644 index 0000000..a97e218 --- /dev/null +++ b/src/mainboard/emulation/qemu-i440fx/board.fmd @@ -0,0 +1,16 @@ +# layout for firmware residing at top of 4GB address space +# +-------------+ <-- 4GB - ROM_SIZE / start of flash +# | unspecified | +# +-------------+ <-- 4GB - BIOS_SIZE +# | FMAP | +# +-------------+ <-- 4GB - BIOS_SIZE + FMAP_SIZE +# | CBFS | +# +-------------+ <-- 4GB / end of flash +FLASH@4278190080 0x1000000 { + BIOS@0 0x1000000 { + FMAP@0 0x200 + RO_VPD@0x200 0x10000 + RW_VPD@0x10200 0x1000 + COREBOOT(CBFS)@0x11200 + } +} diff --git a/src/mainboard/emulation/qemu-q35/board.fmd b/src/mainboard/emulation/qemu-q35/board.fmd new file mode 100644 index 0000000..a97e218 --- /dev/null +++ b/src/mainboard/emulation/qemu-q35/board.fmd @@ -0,0 +1,16 @@ +# layout for firmware residing at top of 4GB address space +# +-------------+ <-- 4GB - ROM_SIZE / start of flash +# | unspecified | +# +-------------+ <-- 4GB - BIOS_SIZE +# | FMAP | +# +-------------+ <-- 4GB - BIOS_SIZE + FMAP_SIZE +# | CBFS | +# +-------------+ <-- 4GB / end of flash +FLASH@4278190080 0x1000000 { + BIOS@0 0x1000000 { + FMAP@0 0x200 + RO_VPD@0x200 0x10000 + RW_VPD@0x10200 0x1000 + COREBOOT(CBFS)@0x11200 + } +}
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32144 )
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32144/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32144/2//COMMIT_MSG@14 PS2, Line 14: Hi John, the commit message needs a signed-off-by line.
https://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32144
to look at the new patch set (#3).
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Add default boards for qemu, that has VPD partitions.
Tested with https://review.coreboot.org/c/coreboot/+/31984 and the 'vpd' command to add VPD variables to those partitions, then checked that they were exported to userspace.
Change-Id: I2aca55543cb3bdbdb77c8b421cbbafad2405d3cc Signed-off-by: John Looney john.looney@gmail.com --- A src/mainboard/emulation/qemu-i440fx/board.fmd A src/mainboard/emulation/qemu-q35/board.fmd 2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/32144/3
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32144 )
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/board.fmd:
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 3: # | unspecified | there's no unspecified in your fmap
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 9: 4278190080 offset in hex too
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-i440fx/... PS3, Line 10: BIOS@0 0x1000000 { the default size is 256KB as set per Kconfig BOARD_ROMSIZE_KB_256
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... File src/mainboard/emulation/qemu-q35/board.fmd:
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... PS3, Line 3: # | unspecified | there's no unspecified in the fmap
https://review.coreboot.org/#/c/32144/3/src/mainboard/emulation/qemu-q35/boa... PS3, Line 10: BIOS@0 0x1000000 { the default size is 2MiB per Kconfig BOARD_ROMSIZE_KB_2048
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32144?usp=email )
Change subject: Add default boards for qemu, that has VPD partitions. ......................................................................
Abandoned
-
John Looney (Code Review) -
Martin Roth (Code Review)
-
Patrick Rudolph (Code Review)
-
Stefan Reinauer (Code Review)