Attention is currently required from: Erik van den Bogaert, Felix Singer, Harrie Paijmans.
Maxim Polyakov has posted comments on this change by Harrie Paijmans. ( https://review.coreboot.org/c/coreboot/+/87198?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: superio/fintek: Add support for f81966d
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87198/comment/ef3e5ef6_978f5386?usp... :
PS2, Line 16: TEST
Yes, now verified with 'superiotool -de'
Please add information about this in the commit message TEST=.... and verified with 'superiotool -de'
File src/superio/fintek/f81966d/f81966d_hwm.c:
https://review.coreboot.org/c/coreboot/+/87198/comment/66cfaa01_f8b76e9f?usp... :
PS3, Line 27: pnp_enter_conf_mode(dev);
There is no need to set the configuration mode for HWM, doesn't break initialization, it's just not necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87198?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibe3987b6e15eb07b92d7f5a7de2bd511de85e2f7
Gerrit-Change-Number: 87198
Gerrit-PatchSet: 3
Gerrit-Owner: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Harrie Paijmans
hpaijmans@eltan.com
Gerrit-Comment-Date: Thu, 10 Apr 2025 15:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Harrie Paijmans
hpaijmans@eltan.com