Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37867 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37867/5/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37867/5/src/ec/google/chromeec/ec.c... PS5, Line 1443: 0
USB_PD_CTRL_MUX_NO_CHANGE
Done
https://review.coreboot.org/c/coreboot/+/37867/5/src/ec/google/chromeec/ec.c... PS5, Line 1444: 0
USB_PD_CTRL_SWAP_NONE
Done
https://review.coreboot.org/c/coreboot/+/37867/7/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37867/7/src/ec/google/chromeec/ec.c... PS7, Line 1457: return 0;
This will need to be done in a cleanup patch after this as the entire ec. […]
Ack
https://review.coreboot.org/c/coreboot/+/37867/7/src/ec/google/chromeec/ec.c... PS7, Line 1492: void
*num_port […]
Done
-
Brandon Breitenstein (Code Review)