Sakari Ailus has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
mb/google/poppy: Rework OV13858 power on sequence
In particular:
- Set voltage before enabling regulators
- Enable regulators and the clock without any sleeping in between. There's no need to wait there.
- Sleep 1 ms in order to wait for regulator voltages settling before lifting xshutdown.
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I0f8857ae369d5038f293a0e2c48c681df535ad86 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 17 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36744/1
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 355b255..fc23d06 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -468,23 +468,33 @@ C0GP = 1 }
- VACT = 1 if (LNotEqual (ACVA, 109)) { /* Set ANA at 2.8152V */ ACVA = 109 } - Sleep(3) + VACT = 1
- _SB.PCI0.I2C2.PMIC.CLKE() - CLE0 = 1 - - VDCT = 1 if (LNotEqual (DCVA, 12)) { /* Set CORE at 1.2V */ DCVA = 12 } - Sleep(3) + VDCT = 1 + + _SB.PCI0.I2C2.PMIC.CLKE() + CLE0 = 1 + + /* + * Wait for all regulator + * outputs to settle. + */ + Sleep(1) + _SB.PCI0.I2C2.PMIC.CRST(1) + + /* + * 5 ms needed before + * streaming on. + */ Sleep(5)
STA = 1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36744/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36744/1//COMMIT_MSG@18 PS1, Line 18: BUG=chromium:959232
Furquan Shaikh has uploaded a new patch set (#2) to the change originally created by Sakari Ailus. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
mb/google/poppy: Rework OV13858 power on sequence
In particular:
- Set voltage before enabling regulators
- Enable regulators and the clock without any sleeping in between. There's no need to wait there.
- Sleep 1 ms in order to wait for regulator voltages settling before lifting xshutdown.
BUG=chromium:959232
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I0f8857ae369d5038f293a0e2c48c681df535ad86 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 17 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/36744/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36744/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36744/1//COMMIT_MSG@18 PS1, Line 18:
BUG=chromium:959232
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36744 )
Change subject: mb/google/poppy: Rework OV13858 power on sequence ......................................................................
mb/google/poppy: Rework OV13858 power on sequence
In particular:
- Set voltage before enabling regulators
- Enable regulators and the clock without any sleeping in between. There's no need to wait there.
- Sleep 1 ms in order to wait for regulator voltages settling before lifting xshutdown.
BUG=chromium:959232
Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I0f8857ae369d5038f293a0e2c48c681df535ad86 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36744 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 17 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 355b255..fc23d06 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -468,23 +468,33 @@ C0GP = 1 }
- VACT = 1 if (LNotEqual (ACVA, 109)) { /* Set ANA at 2.8152V */ ACVA = 109 } - Sleep(3) + VACT = 1
- _SB.PCI0.I2C2.PMIC.CLKE() - CLE0 = 1 - - VDCT = 1 if (LNotEqual (DCVA, 12)) { /* Set CORE at 1.2V */ DCVA = 12 } - Sleep(3) + VDCT = 1 + + _SB.PCI0.I2C2.PMIC.CLKE() + CLE0 = 1 + + /* + * Wait for all regulator + * outputs to settle. + */ + Sleep(1) + _SB.PCI0.I2C2.PMIC.CRST(1) + + /* + * 5 ms needed before + * streaming on. + */ Sleep(5)
STA = 1
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Sakari Ailus (Code Review)