Attention is currently required from: Andrey Petrov, Angel Pons, David Hendricks, Krystian Hebel, Martin L Roth, Matt DeVillier, Michał Żygowski, Paul Menzel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67059?usp=email )
Change subject: device/dram: add DDR4 MRS commands
......................................................................
Patch Set 11:
(1 comment)
File src/include/device/dram/ddr4.h:
https://review.coreboot.org/c/coreboot/+/67059/comment/6b36ff34_50860108 :
PS11, Line 106: typedef u32 mrs_cmd_t;
Nit: We prefer not to use typedefs unless there's a specific reason to. […]
Changed to `uint32_t` and added comments to note that MRS command is being returned.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67059?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d4f048c859bc89897d50a5a07468c3375aa1dcf
Gerrit-Change-Number: 67059
Gerrit-PatchSet: 11
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
anpetrov@fb.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 18:03:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment