Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33427
Change subject: hatch: Fix pen eject polarity ......................................................................
hatch: Fix pen eject polarity
The gpio_key wakeup_event_action in the ACPI tables was backwards, causing devices to wake up on pen insertion instead of removal. Changed to EV_ACT_DEASSERTED.
BUG=b:134547896 BRANCH=none TEST=Verified in OS, device only wakes up on pen removal
Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb M src/mainboard/google/hatch/variants/kindred/overridetree.cb 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33427/1
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 562bb8b..3846b60 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -88,7 +88,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index eec7880..fe7869d 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -73,7 +73,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 405f85f..2e46fd9 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -96,7 +96,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 562bb8b..3846b60 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -88,7 +88,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW"
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject polarity ......................................................................
Patch Set 1: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... PS1, Line 89: register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" Maybe we set EDGE_HIGH here and let kernel set as both? I think this active high actually. You can found our experiment in issue.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject polarity ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch/overridetree.cb:
https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... PS1, Line 89: register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"
Maybe we set EDGE_HIGH here and let kernel set as both? I think this active high actually. […]
The reason I left it this way is for documentation purposes: someone looking at the device tree doesn't have to wonder why it's only set here to generate interrupts on one edge, and know that the kernel driver (which may change) is setting up for both edges regardless.
Hello EricR Lai, Paul Fagerburg, Dtrain Hsu, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33427
to look at the new patch set (#2).
Change subject: hatch: Fix pen eject wake polarity ......................................................................
hatch: Fix pen eject wake polarity
The gpio_key wakeup_event_action in the ACPI tables was backwards, causing devices to wake up on pen insertion instead of removal. Changed to EV_ACT_DEASSERTED.
BUG=b:134547896 BRANCH=none TEST=Verified in OS, device only wakes up on pen removal
Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb M src/mainboard/google/hatch/variants/kindred/overridetree.cb 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33427/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/... PS2, Line 99: EV_ACT_DEASSERTED Is this true for helios as well? i.e. similar polarity?
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/#/c/33427/2/src/mainboard/google/hatch/variants/... PS2, Line 91: EV_ACT_DEASSERTED ... and kindred too?
Hello EricR Lai, Paul Fagerburg, Dtrain Hsu, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33427
to look at the new patch set (#3).
Change subject: hatch: Fix pen eject wake polarity ......................................................................
hatch: Fix pen eject wake polarity
The gpio_key wakeup_event_action in the ACPI tables was backwards, causing devices to wake up on pen insertion instead of removal. Changed to EV_ACT_DEASSERTED.
BUG=b:134547896 BRANCH=none TEST=Verified in OS, device only wakes up on pen removal
Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb M src/mainboard/google/hatch/variants/kindred/overridetree.cb 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33427/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity ......................................................................
Patch Set 3: Code-Review+2
Hello EricR Lai, Paul Fagerburg, Dtrain Hsu, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33427
to look at the new patch set (#4).
Change subject: hatch: Fix pen eject wake polarity ......................................................................
hatch: Fix pen eject wake polarity
The gpio_key wakeup_event_action in the ACPI tables was backwards, causing devices to wake up on pen insertion instead of removal. Changed to EV_ACT_DEASSERTED.
BUG=b:134547896 BRANCH=none TEST=Verified in OS, device only wakes up on pen removal
Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33427/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33427 )
Change subject: hatch: Fix pen eject wake polarity ......................................................................
hatch: Fix pen eject wake polarity
The gpio_key wakeup_event_action in the ACPI tables was backwards, causing devices to wake up on pen insertion instead of removal. Changed to EV_ACT_DEASSERTED.
BUG=b:134547896 BRANCH=none TEST=Verified in OS, device only wakes up on pen removal
Change-Id: I0816ed9fb23cf00fd8e40bcdd25ff7a9f48badbd Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/33427 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 562bb8b..3846b60 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -88,7 +88,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" diff --git a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb index eec7880..fe7869d 100644 --- a/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb @@ -73,7 +73,7 @@ register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)" register "key.wake" = "GPE0_DW0_08" - register "key.wakeup_event_action" = "EV_ACT_ASSERTED" + register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW"
-
EricR Lai (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Fagerburg (Code Review)
-
Tim Wawrzynczak (Code Review)