Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40287 )
Change subject: nb/intel/i945: Add VBOOT support ......................................................................
nb/intel/i945: Add VBOOT support
Change-Id: I749be0044be04b044ff82e96aff8093f4b0d295e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i945/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40287/1
diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index c22275a..cd28846 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -28,6 +28,10 @@ select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select PARALLEL_MP
+config VBOOT + select VBOOT_STARTS_IN_BOOTBLOCK + select VBOOT_SEPARATE_VERSTAGE + config NORTHBRIDGE_INTEL_SUBTYPE_I945GC def_bool n config NORTHBRIDGE_INTEL_SUBTYPE_I945GM
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40287 )
Change subject: nb/intel/i945: Add VBOOT support ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40287/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40287/1//COMMIT_MSG@7 PS1, Line 7: VBOOT lowercase? vboot
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40287
to look at the new patch set (#2).
Change subject: nb/intel/i945: Add vboot support ......................................................................
nb/intel/i945: Add vboot support
Change-Id: I749be0044be04b044ff82e96aff8093f4b0d295e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/i945/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/40287/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40287 )
Change subject: nb/intel/i945: Add vboot support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40287/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40287/1//COMMIT_MSG@7 PS1, Line 7: VBOOT
lowercase? vboot
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40287 )
Change subject: nb/intel/i945: Add vboot support ......................................................................
nb/intel/i945: Add vboot support
Change-Id: I749be0044be04b044ff82e96aff8093f4b0d295e Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/40287 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/Kconfig b/src/northbridge/intel/i945/Kconfig index 2abc201..4690a54 100644 --- a/src/northbridge/intel/i945/Kconfig +++ b/src/northbridge/intel/i945/Kconfig @@ -27,6 +27,10 @@ select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select PARALLEL_MP
+config VBOOT + select VBOOT_STARTS_IN_BOOTBLOCK + select VBOOT_SEPARATE_VERSTAGE + config NORTHBRIDGE_INTEL_SUBTYPE_I945GC def_bool n config NORTHBRIDGE_INTEL_SUBTYPE_I945GM
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)