[L] Change in coreboot[main]: mb/topton/adl: Add initial support for X2F N100 FW appliance

[Angel Pons (Code Review)]

Attention is currently required from: Alicja Michalska.

Angel Pons has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/84175?usp=email )

Change subject: mb/topton/adl: Add initial support for X2F N100 FW appliance
......................................................................

Patch Set 9:

(3 comments)

File src/mainboard/topton/adl/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/84175/comment/cc7b6253_5d81c9be?usp... :
PS2, Line 43: 		# TODO: SATA doesn't work. EDK2 returns "Unsupported", not sure how to fix (yet).
> I believe ADL-N has two SATA ports, but when I tried adding what you just mentioned - drive wasn't r […]

Okay, then I would leave the SATA ports enabled in the devicetree since that's correct.

Regarding GPIOs: I think there's some GPIOs that control SATA/PCIe muxing. Could it be that some lanes are shared between SATA and PCIe (e.g. NVMe)?

File src/mainboard/topton/adl/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/84175/comment/7fd2eca4_827eddb9?usp... :
PS9, Line 99: 			chip superio/ite/it8625e
Does fan control work?

File src/mainboard/topton/adl/mainboard.c:

https://review.coreboot.org/c/coreboot/+/84175/comment/bccfc564_2cb88f59?usp... :
PS9, Line 17: 	params->PchLegacyIoLowLatency = 1;
> It disables some DMI-related power saving features, I probably could remove it if I do a bit more te […]

Okay, fair enough. I would either add a short comment (`Disable DMI/PCIe ASPM to work around NVMe instability`) or remove it if it's not needed.