Attention is currently required from: Subrata Banik, Nick Vaccaro, Benson Leung, Prashant Malani.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61571 )
Change subject: mb/google/brya: Add custom PLD fields to devicetree for brya variants
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
Where did you get the positional information for each variant? […]
Hi Nick, thank you for review. I have added a description and charts regarding the PLD values in go/custompldrequirement. Basically, I traced each port in schematics, searched for it in board layout, and compared it with ports on actual physical device.
Do you think I should add a hw engineer as reviewer to verify these positions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61571
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If610e6b3c849d982345ed1b8607ffd2af105dc51
Gerrit-Change-Number: 61571
Gerrit-PatchSet: 4
Gerrit-Owner: Won Chung
wonchung@google.com
Gerrit-Reviewer: Benson Leung
bleung@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen Wisley
wisley.chen@quantatw.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Benson Leung
bleung@chromium.org
Gerrit-Attention: Prashant Malani
pmalani@chromium.org
Gerrit-Comment-Date: Sat, 05 Feb 2022 00:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment