Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30239 )
Change subject: mb/lenovo/thinkcentre_a58: Add mainboard ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58... File src/mainboard/lenovo/thinkcentre_a58/board_info.txt:
https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58... PS1, Line 2: https://ark.intel.com/products/48621/Intel-Desktop-Board-DG41WV Is this URL correct?
https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58... File src/mainboard/lenovo/thinkcentre_a58/cmos.layout:
https://review.coreboot.org/#/c/30239/1/src/mainboard/lenovo/thinkcentre_a58... PS1, Line 81: 6 1 Emergency : 6 2 Alert : 6 3 Critical : 6 4 Error : 6 5 Warning : 6 6 Notice : 6 7 Info : 6 8 Debug : 6 9 Spew These are off by 1.
-
Tristan Corrick (Code Review)