Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/42359 )
Change subject: Add Bay Trail support ......................................................................
Patch Set 36:
(3 comments)
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx... File common/valleyview/hw-gfx-gma-plls.adb:
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx... PS34, Line 421: elsif Target_Clock <= 340_000_000 then Maximum is 300MHz, `VCO_Upper / P1_Lower / P2_Lower / 5`.
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx... PS34, Line 425: -- should be, but doesn't always have to be the same: Stale comment. We have different copies of the code for each refclock currently.
https://review.coreboot.org/c/libgfxinit/+/42359/34/common/valleyview/hw-gfx... PS34, Line 434: pragma Debug (Debug.Put_Int32 (340_000_000)); 300MHz
-
Nico Huber (Code Review)