Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43138 )
Change subject: soc/intel: Drop unused `#include <reg_script.h>` ......................................................................
soc/intel: Drop unused `#include <reg_script.h>`
In some cases, the SoC did not even select `REG_SCRIPT` in Kconfig.
Change-Id: I617f332b80c534997e06a91247d1be90a85573be Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/baytrail/sd.c M src/soc/intel/braswell/sd.c M src/soc/intel/broadwell/romstage/power_state.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/cannonlake/lpc.c M src/soc/intel/denverton_ns/cpu.c M src/soc/intel/icelake/espi.c M src/soc/intel/icelake/finalize.c M src/soc/intel/jasperlake/espi.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/skylake/finalize.c M src/soc/intel/tigerlake/espi.c M src/soc/intel/tigerlake/finalize.c 13 files changed, 0 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43138/1
diff --git a/src/soc/intel/baytrail/sd.c b/src/soc/intel/baytrail/sd.c index 6e4179c..57cd8f4 100644 --- a/src/soc/intel/baytrail/sd.c +++ b/src/soc/intel/baytrail/sd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <reg_script.h>
#include <soc/iosf.h> #include <soc/nvs.h> diff --git a/src/soc/intel/braswell/sd.c b/src/soc/intel/braswell/sd.c index edb5e77..34dd835 100644 --- a/src/soc/intel/braswell/sd.c +++ b/src/soc/intel/braswell/sd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <reg_script.h>
#include <soc/iosf.h> #include <soc/nvs.h> diff --git a/src/soc/intel/broadwell/romstage/power_state.c b/src/soc/intel/broadwell/romstage/power_state.c index 8128458..cb1d3e5 100644 --- a/src/soc/intel/broadwell/romstage/power_state.c +++ b/src/soc/intel/broadwell/romstage/power_state.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <reg_script.h> #include <string.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c index 49e9d7f..315c67a 100644 --- a/src/soc/intel/cannonlake/finalize.c +++ b/src/soc/intel/cannonlake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index 47a7b71..50af9ee 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/iomap.h> #include <soc/irq.h> #include <soc/lpc.h> diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c index 9764a3e..b1eda9b 100644 --- a/src/soc/intel/denverton_ns/cpu.c +++ b/src/soc/intel/denverton_ns/cpu.c @@ -12,7 +12,6 @@ #include <device/device.h> #include <device/pci.h> #include <intelblocks/cpulib.h> -#include <reg_script.h>
#include <soc/msr.h> #include <soc/cpu.h> diff --git a/src/soc/intel/icelake/espi.c b/src/soc/intel/icelake/espi.c index 2b98d9e..1497c8d 100644 --- a/src/soc/intel/icelake/espi.c +++ b/src/soc/intel/icelake/espi.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/icelake/finalize.c b/src/soc/intel/icelake/finalize.c index fdeaaad..53e3cba 100644 --- a/src/soc/intel/icelake/finalize.c +++ b/src/soc/intel/icelake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/espi.c b/src/soc/intel/jasperlake/espi.c index a1954fd..bf82067 100644 --- a/src/soc/intel/jasperlake/espi.c +++ b/src/soc/intel/jasperlake/espi.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/jasperlake/finalize.c b/src/soc/intel/jasperlake/finalize.c index d16080f..08a6bab 100644 --- a/src/soc/intel/jasperlake/finalize.c +++ b/src/soc/intel/jasperlake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index dbb451c..98f12a5 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -15,7 +15,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/me.h> #include <soc/p2sb.h> diff --git a/src/soc/intel/tigerlake/espi.c b/src/soc/intel/tigerlake/espi.c index 8cc8303..513da5a 100644 --- a/src/soc/intel/tigerlake/espi.c +++ b/src/soc/intel/tigerlake/espi.c @@ -16,7 +16,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/tigerlake/finalize.c b/src/soc/intel/tigerlake/finalize.c index d0dc30e..534abd9 100644 --- a/src/soc/intel/tigerlake/finalize.c +++ b/src/soc/intel/tigerlake/finalize.c @@ -17,7 +17,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h>
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43138 )
Change subject: soc/intel: Drop unused `#include <reg_script.h>` ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43138 )
Change subject: soc/intel: Drop unused `#include <reg_script.h>` ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/43138 )
Change subject: soc/intel: Drop unused `#include <reg_script.h>` ......................................................................
Removed Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43138 )
Change subject: soc/intel: Drop unused `#include <reg_script.h>` ......................................................................
soc/intel: Drop unused `#include <reg_script.h>`
In some cases, the SoC did not even select `REG_SCRIPT` in Kconfig.
Change-Id: I617f332b80c534997e06a91247d1be90a85573be Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43138 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/soc/intel/baytrail/sd.c M src/soc/intel/braswell/sd.c M src/soc/intel/broadwell/romstage/power_state.c M src/soc/intel/cannonlake/finalize.c M src/soc/intel/cannonlake/lpc.c M src/soc/intel/denverton_ns/cpu.c M src/soc/intel/icelake/espi.c M src/soc/intel/icelake/finalize.c M src/soc/intel/jasperlake/espi.c M src/soc/intel/jasperlake/finalize.c M src/soc/intel/skylake/finalize.c M src/soc/intel/tigerlake/espi.c M src/soc/intel/tigerlake/finalize.c 13 files changed, 0 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/baytrail/sd.c b/src/soc/intel/baytrail/sd.c index 6e4179c..57cd8f4 100644 --- a/src/soc/intel/baytrail/sd.c +++ b/src/soc/intel/baytrail/sd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <reg_script.h>
#include <soc/iosf.h> #include <soc/nvs.h> diff --git a/src/soc/intel/braswell/sd.c b/src/soc/intel/braswell/sd.c index edb5e77..34dd835 100644 --- a/src/soc/intel/braswell/sd.c +++ b/src/soc/intel/braswell/sd.c @@ -5,7 +5,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <reg_script.h>
#include <soc/iosf.h> #include <soc/nvs.h> diff --git a/src/soc/intel/broadwell/romstage/power_state.c b/src/soc/intel/broadwell/romstage/power_state.c index 8128458..cb1d3e5 100644 --- a/src/soc/intel/broadwell/romstage/power_state.c +++ b/src/soc/intel/broadwell/romstage/power_state.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> -#include <reg_script.h> #include <string.h> #include <soc/iomap.h> #include <soc/lpc.h> diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c index 49e9d7f..315c67a 100644 --- a/src/soc/intel/cannonlake/finalize.c +++ b/src/soc/intel/cannonlake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index 47a7b71..50af9ee 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/iomap.h> #include <soc/irq.h> #include <soc/lpc.h> diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c index 9764a3e..b1eda9b 100644 --- a/src/soc/intel/denverton_ns/cpu.c +++ b/src/soc/intel/denverton_ns/cpu.c @@ -12,7 +12,6 @@ #include <device/device.h> #include <device/pci.h> #include <intelblocks/cpulib.h> -#include <reg_script.h>
#include <soc/msr.h> #include <soc/cpu.h> diff --git a/src/soc/intel/icelake/espi.c b/src/soc/intel/icelake/espi.c index 2b98d9e..1497c8d 100644 --- a/src/soc/intel/icelake/espi.c +++ b/src/soc/intel/icelake/espi.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/icelake/finalize.c b/src/soc/intel/icelake/finalize.c index fdeaaad..53e3cba 100644 --- a/src/soc/intel/icelake/finalize.c +++ b/src/soc/intel/icelake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/jasperlake/espi.c b/src/soc/intel/jasperlake/espi.c index a1954fd..bf82067 100644 --- a/src/soc/intel/jasperlake/espi.c +++ b/src/soc/intel/jasperlake/espi.c @@ -10,7 +10,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/jasperlake/finalize.c b/src/soc/intel/jasperlake/finalize.c index d16080f..08a6bab 100644 --- a/src/soc/intel/jasperlake/finalize.c +++ b/src/soc/intel/jasperlake/finalize.c @@ -11,7 +11,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h> diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index dbb451c..98f12a5 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -15,7 +15,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/me.h> #include <soc/p2sb.h> diff --git a/src/soc/intel/tigerlake/espi.c b/src/soc/intel/tigerlake/espi.c index 8cc8303..513da5a 100644 --- a/src/soc/intel/tigerlake/espi.c +++ b/src/soc/intel/tigerlake/espi.c @@ -16,7 +16,6 @@ #include <intelblocks/itss.h> #include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <reg_script.h> #include <soc/espi.h> #include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/tigerlake/finalize.c b/src/soc/intel/tigerlake/finalize.c index d0dc30e..534abd9 100644 --- a/src/soc/intel/tigerlake/finalize.c +++ b/src/soc/intel/tigerlake/finalize.c @@ -17,7 +17,6 @@ #include <intelblocks/pcr.h> #include <intelblocks/tco.h> #include <intelblocks/thermal.h> -#include <reg_script.h> #include <spi-generic.h> #include <soc/p2sb.h> #include <soc/pci_devs.h>
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Subrata Banik (Code Review)