Change in coreboot[master]: tests: Add test region and symbol macros to <tests/test.h>

[Name of user not set (Code Review)]

Name of user not set #1003143 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

tests: Add test region and symbol macros to <tests/test.h>

Some modules require and operate on memory regions and symbols.
This macros systematize how they are defined in testing code.

Signed-off-by: Jakub Czapiga 
Change-Id: I314028c201732416bb3d5446a4c8585e055073e3
---
M tests/include/tests/test.h
1 file changed, 13 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/46684/1

diff --git a/tests/include/tests/test.h b/tests/include/tests/test.h
index 4dc9988..6d6d6d9 100644
--- a/tests/include/tests/test.h
+++ b/tests/include/tests/test.h
@@ -14,4 +14,17 @@
 #include <setjmp.h>
 #include <cmocka.h>

+/*
+ * Set symbol value and make it global.
+ */
+#define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol )
+
+/*
+ * Define memory region for testing purpose.
+ *
+ * Create buffer with specified name and size.
+ * Create end symbol for it.
+ */
+#define TEST_REGION(region, size) uint8_t _##region[size]; TEST_SYMBOL(_e##region, _##region + size)
+
 #endif /* _TESTS_TEST_H */

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h 
File tests/include/tests/test.h:

https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... 
PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol )
space prohibited after that open parenthesis '('

https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... 
PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol )
space prohibited before that close parenthesis ')'

https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... 
PS1, Line 20: #define TEST_SYMBOL(symbol, address) asm ( ".set " #symbol ", " #address "\n\t.globl " #symbol )
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/c/coreboot/+/46684/1/tests/include/tests/test.h@... 
PS1, Line 28: #define TEST_REGION(region, size) uint8_t _##region[size]; TEST_SYMBOL(_e##region, _##region + size)
line over 96 characters

[Name of user not set (Code Review)]

Name of user not set #1003143 has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

tests: Add test region and symbol macros to <tests/test.h>

Some modules require and operate on memory regions and symbols.
This macros systematize how they are defined in testing code.

Signed-off-by: Jakub Czapiga 
Change-Id: I314028c201732416bb3d5446a4c8585e055073e3
---
M tests/include/tests/test.h
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/46684/2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

Patch Set 2: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

Patch Set 2: Code-Review+1

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46684 )

Change subject: tests: Add test region and symbol macros to <tests/test.h>
......................................................................

tests: Add test region and symbol macros to <tests/test.h>

Some modules require and operate on memory regions and symbols.
This macros systematize how they are defined in testing code.

Signed-off-by: Jakub Czapiga 
Change-Id: I314028c201732416bb3d5446a4c8585e055073e3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46684
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
Reviewed-by: Angel Pons 
Reviewed-by: Paul Fagerburg 
---
M tests/include/tests/test.h
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved
  Angel Pons: Looks good to me, but someone else must approve
  Paul Fagerburg: Looks good to me, approved

diff --git a/tests/include/tests/test.h b/tests/include/tests/test.h
index 4dc9988..ceb9654 100644
--- a/tests/include/tests/test.h
+++ b/tests/include/tests/test.h
@@ -14,4 +14,18 @@
 #include <setjmp.h>
 #include <cmocka.h>

+/*
+ * Set symbol value and make it global.
+ */
+#define TEST_SYMBOL(symbol, address) asm(".set " #symbol ", " #address "\n\t.globl " #symbol)
+
+/*
+ * Define memory region for testing purpose.
+ *
+ * Create buffer with specified name and size.
+ * Create end symbol for it.
+ */
+#define TEST_REGION(region, size) uint8_t _##region[size]; \
+	TEST_SYMBOL(_e##region, _##region + size)
+
 #endif /* _TESTS_TEST_H */