Attention is currently required from: Bao Zheng, Felix Held, Marshall Dawson, Martin Roth, Zheng Bao.
Hello Felix Held, Marshall Dawson, Martin Roth, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78311?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed: Code-Review+2 by Felix Held, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: amdfwtool: Move code related to getting options to a new file ......................................................................
amdfwtool: Move code related to getting options to a new file
Cleanup the messy code. The code left in main is all about filling tables.
To help to do this, 1. Some local variables are put into global struct. 2. Add some functions. Set some functions to global.
TEST=Identical test on all AMD platforms
Change-Id: Ia25c3fd5de7ae48054359f0f6551d91d7a4f6828 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/Makefile.mk M util/amdfwtool/amdfwtool.c M util/amdfwtool/amdfwtool.h A util/amdfwtool/opts.c 4 files changed, 795 insertions(+), 760 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/78311/9