Attention is currently required from: Jianeng Ceng, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81773/comment/65494596_1c15b514 : PS9, Line 9: Add RT5645 AMP support. Please elaborate.
1. Why can’t `src/drivers/i2c/rt5663/` be generalized? 2. Please document the datasheet name and revision.
https://review.coreboot.org/c/coreboot/+/81773/comment/4d86a8db_fab02990 : PS9, Line 12: Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realtek.com/) Please put the URL on a separate line without brackets.
https://review.coreboot.org/c/coreboot/+/81773/comment/9ce00ebd_f7b63a90 : PS9, Line 15: TEST=RT5645 driver can probe properly. Please name the device, and paste the relevant log messages.