Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and trackpad gpio settings.

[Stanley Wu (Code Review)]

Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and trackpad gpio settings.
......................................................................

mb/google/volteer: Update I2C5 bus freq and trackpad gpio settings.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.

BUG=b:160013582
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/1

diff --git a/src/mainboard/google/volteer/variants/lindar/gpio.c b/src/mainboard/google/volteer/variants/lindar/gpio.c
index 4f3d5f7..f99ffbd 100644
--- a/src/mainboard/google/volteer/variants/lindar/gpio.c
+++ b/src/mainboard/google/volteer/variants/lindar/gpio.c
@@ -134,6 +134,9 @@
    /* C21 : UART2_TXD ==> H1_PCH_INT_ODL */
    PAD_CFG_GPI_APIC(GPP_C21, NONE, PLTRST, LEVEL, INVERT),

+	/* E15 : ISH_GP6 ==> NC */
+	PAD_NC(GPP_E15, NONE),
+
    /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */
    PAD_CFG_GPO(GPP_H11, 1, DEEP),
 };
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index 2e61071..7bdb625 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -9,6 +9,44 @@
    register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)"	# USB3/2 Type A port A0

register "SaGv" = "SaGv_Disabled"
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| chipset_lockdown  | CHIPSET_LOCKDOWN_COREBOOT |
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| GSPI1             | Fingerprint MCU           |
+	#| I2C0              | Audio                     |
+	#| I2C1              | Touchscreen               |
+	#| I2C5              | Trackpad                  |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 0,
+			.fall_time_ns = 0,
+			.data_hold_time_ns = 0,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 163,
+				.scl_hcnt = 75,
+				.sda_hold = 36,
+			},
+		},
+	}"
    # I2C Port Config
    register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48150

to look at the new patch set (#2).

Change subject: mb/google/volteer: Update I2C5 bus freq and trackpad gpio settings.
......................................................................

mb/google/volteer: Update I2C5 bus freq and trackpad gpio settings.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/2

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48150

to look at the new patch set (#3).

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

mb/google/volteer: Update I2C5 bus freq and devicetree.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.
Imporve Goodix Touchscreen power on sequence.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 43 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/3

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48150/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48150/3//COMMIT_MSG@11 
PS3, Line 11: Imporve
Correct

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Tim Wawrzynczak, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48150

to look at the new patch set (#4).

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

mb/google/volteer: Update I2C5 bus freq and devicetree.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.
Improve Goodix Touchscreen power on sequence.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 43 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/4

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Stanley Wu (Code Review)]

Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48150/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/48150/3//COMMIT_MSG@11 
PS3, Line 11: Imporve
> Correct

Done

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 4: Code-Review+1

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Zhuohao Lee (Code Review)]

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/gpio.c:

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
PS4, Line 137: 	/* E15 : ISH_GP6 ==> NC */
             : 	PAD_NC(GPP_E15, NONE),
             : 
May i know the reason behind of setting this?

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
PS4, Line 39: 			.rise_time_ns = 0,
            : 			.fall_time_ns = 0,
            : 			.data_hold_time_ns = 0,
Is this needed? I think the default value should be zero, isn't it?

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Stanley Wu (Code Review)]

Hello build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48150

to look at the new patch set (#5).

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

mb/google/volteer: Update I2C5 bus freq and devicetree.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.
Improve Goodix Touchscreen power on sequence.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 40 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/5

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Stanley Wu (Code Review)]

Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/gpio.c:

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
PS4, Line 137: 	/* E15 : ISH_GP6 ==> NC */
             : 	PAD_NC(GPP_E15, NONE),
             :
> May i know the reason behind of setting this?

Because TRACKPAD_INT_ODL pin no response on Synaptics trackpad device after power on. And it can be fixed after config GPP_E15 to early GPIO table.

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/48150/4/src/mainboard/google/voltee... 
PS4, Line 39: 			.rise_time_ns = 0,
            : 			.fall_time_ns = 0,
            : 			.data_hold_time_ns = 0,
> Is this needed? I think the default value should be zero, isn't it?

You`re right, i remove useless code change.

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Kevin Chang (Code Review)]

Kevin Chang has uploaded a new patch set (#6) to the change originally created by Stanley Wu. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

mb/google/volteer: Update I2C5 bus freq and devicetree.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.
Improve Goodix Touchscreen power on sequence.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 40 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/48150/6

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/google/volteer: Update I2C5 bus freq and devicetree.

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48150 )

Change subject: mb/google/volteer: Update I2C5 bus freq and devicetree.
......................................................................

mb/google/volteer: Update I2C5 bus freq and devicetree.

Update lindar gpio settings for Synaptics trackpad no function issue.
Update I2C5 bus freq to 400kHz.
Improve Goodix Touchscreen power on sequence.

BUG=b:160013582
BRANCH=firmware-volteer-13521.B
TEST=emerge-volteer coreboot and check system dmesg and evtest can get
device. Verify trackpad function workable.

Signed-off-by: Stanley Wu 
Change-Id: I8c1ab6bab1f9de187e2a78ead7b5bbaf758f5fcf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48150
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Sumeet R Pawnikar 
---
M src/mainboard/google/volteer/variants/lindar/gpio.c
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
2 files changed, 40 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Sumeet R Pawnikar: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/lindar/gpio.c b/src/mainboard/google/volteer/variants/lindar/gpio.c
index 08f1401..8b56e0d 100644
--- a/src/mainboard/google/volteer/variants/lindar/gpio.c
+++ b/src/mainboard/google/volteer/variants/lindar/gpio.c
@@ -137,6 +137,9 @@
    /* D16 : ISH_UART0_CTS# ==> EN_PP3300_SD */
    PAD_CFG_GPO(GPP_D16, 1, DEEP),

+	/* E15 : ISH_GP6 ==> NC */
+	PAD_NC(GPP_E15, NONE),
+
    /* H11 : SRCCLKREQ5# ==> WLAN_PERST_L */
    PAD_CFG_GPO(GPP_H11, 1, DEEP),
 };
diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index 2e61071..277ba60 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -9,6 +9,41 @@
    register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)"	# USB3/2 Type A port A0

register "SaGv" = "SaGv_Disabled"
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| chipset_lockdown  | CHIPSET_LOCKDOWN_COREBOOT |
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| GSPI1             | Fingerprint MCU           |
+	#| I2C0              | Audio                     |
+	#| I2C1              | Touchscreen               |
+	#| I2C5              | Trackpad                  |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT,
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[5] = {
+			.speed = I2C_SPEED_FAST,
+			.speed_config[0] = {
+				.speed = I2C_SPEED_FAST,
+				.scl_lcnt = 163,
+				.scl_hcnt = 75,
+				.sda_hold = 36,
+			},
+		},
+	}"
    # I2C Port Config
    register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,
@@ -69,8 +104,8 @@
    			# Parameter T2 >= 1ms
    			register "generic.reset_off_delay_ms" = "3"
    			register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A8)"
-				# Parameter T1 >= 10ms
-				register "generic.enable_delay_ms" = "12"
+				# Parameter T1 >= 20ms
+				register "generic.enable_delay_ms" = "20"
    			register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"
    			# Parameter T4 >= 1ms
    			register "generic.stop_off_delay_ms" = "1"