Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37081 )
Change subject: Makefile: Move libs to the end ......................................................................
Makefile: Move libs to the end
Move LDFLAGS to the end of the linker call. This fixes a linking issue on Ubuntu 19.10
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: If15ca42b8f046e68a232d282bec5fa130340b2f4 --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/81/37081/1
diff --git a/Makefile b/Makefile index 515db64..efba410 100644 --- a/Makefile +++ b/Makefile @@ -45,7 +45,7 @@
em100: $(OBJECTS) printf " LD em100\n" - $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJECTS) + $(CC) $(CFLAGS) -o $@ $(OBJECTS) $(LDFLAGS)
em100pro_chips.h: makechips.sh printf " CREATE em100pro_chips.sh & firmware images\n"
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37081 )
Change subject: Makefile: Move libs to the end ......................................................................
Patch Set 5: Code-Review+2
a classic :-)
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37081 )
Change subject: Makefile: Move libs to the end ......................................................................
Makefile: Move libs to the end
Move LDFLAGS to the end of the linker call. This fixes a linking issue on Ubuntu 19.10
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: If15ca42b8f046e68a232d282bec5fa130340b2f4 Reviewed-on: https://review.coreboot.org/c/em100/+/37081 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/Makefile b/Makefile index d5142ae..698920b 100644 --- a/Makefile +++ b/Makefile @@ -45,7 +45,7 @@
em100: $(OBJECTS) printf " LD em100\n" - $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(OBJECTS) + $(CC) $(CFLAGS) -o $@ $(OBJECTS) $(LDFLAGS)
em100pro_chips.h: makechips.sh printf " CREATE em100pro_chips.sh & firmware images\n"
-
Patrick Georgi (Code Review) -
Stefan Reinauer (Code Review)