Change in coreboot[master]: mb/kontron/ktqm77: Add "Legacy" option to SATA

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in em100[master]: em100:...

Felix Singer (Code Review)

25 Mar 2020 25 Mar '20

9:55 a.m.

Hello Nico Huber,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39829

to review the following change.

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

mb/kontron/ktqm77: Add "Legacy" option to SATA

Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/kontron/ktqm77/cmos.layout 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/39829/1

diff --git a/src/mainboard/kontron/ktqm77/cmos.layout b/src/mainboard/kontron/ktqm77/cmos.layout index f180754..72117ae 100644 --- a/src/mainboard/kontron/ktqm77/cmos.layout +++ b/src/mainboard/kontron/ktqm77/cmos.layout @@ -54,12 +54,12 @@ 400 1 e 2 hyper_threading 401 3 e 12 gfx_uma_size

-#404 4 r 0 unused +#404 3 r 0 unused

# coreboot config options: southbridge -408 1 e 1 nmi -409 2 e 7 power_on_after_fail -411 1 e 11 sata_mode +407 1 e 1 nmi +408 2 e 7 power_on_after_fail +410 2 e 11 sata_mode

# coreboot config options: additional mainboard options 412 4 e 10 systemp_type @@ -130,6 +130,7 @@ 10 4 LM75@9e 11 0 AHCI 11 1 Compatible +11 2 Legacy 12 0 32M 12 1 64M 12 2 96M

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Paul Menzel (Code Review)

1 Apr 1 Apr

12:54 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@7 PS2, Line 7: mb/kontron/ktqm77: Add "Legacy" option to SATA … to SATA mode CMOS option

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@8 PS2, Line 8: Tested how?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Apr 2020 07:54:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

1:34 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Apr 2020 08:34:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

3:04 a.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@8 PS2, Line 8:

...

Tested how?

Well, this is embarrassing:

TEST=Booted Linux 2.6.12 w/o native Intel IDE driver and confirmed working SATA drive.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 01 Apr 2020 10:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Frans Hendriks (Code Review)

6 Apr 6 Apr

5:58 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Apr 2020 12:58:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Singer (Code Review)

6:45 a.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Paul Menzel, Angel Pons, Arthur Heymans,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39829

to look at the new patch set (#6).

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

TEST=Booted Linux 2.6.12 w/o native Intel IDE driver and confirmed working SATA drive.

Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/kontron/ktqm77/cmos.layout 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/39829/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

6:46 a.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@7 PS2, Line 7: mb/kontron/ktqm77: Add "Legacy" option to SATA

...

… to SATA mode CMOS option

Done

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@8 PS2, Line 8:

...

Well, this is embarrassing: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Apr 2020 13:46:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

7:30 a.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@8 PS2, Line 8:

...

Done

Please add it to the commit message.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Apr 2020 14:30:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

7:31 a.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39829/2//COMMIT_MSG@8 PS2, Line 8:

...

Please add it to the commit message.

Done. I looked at the wrong change-set.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Apr 2020 14:31:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer felixsinger@posteo.net Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Felix Singer (Code Review)

7 Apr 7 Apr

2:47 a.m.

Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Paul Menzel, Angel Pons, Arthur Heymans,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39829

to look at the new patch set (#7).

Change subject: mb/kontron/ktqm77: Add "Legacy" option to SATA ......................................................................

mb/kontron/ktqm77: Add "Legacy" option to SATA

Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/kontron/ktqm77/cmos.layout 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/39829/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Felix Singer (Code Review)

3:02 a.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Paul Menzel, Angel Pons, Arthur Heymans,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39829

to look at the new patch set (#8).

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

TEST=Booted Linux 2.6.12 w/o native Intel IDE driver and confirmed working SATA drive.

Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/kontron/ktqm77/cmos.layout 1 file changed, 5 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/39829/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

14 Apr 14 Apr

4:19 p.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Apr 2020 23:19:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

15 Apr 15 Apr

2:10 p.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

TEST=Booted Linux 2.6.12 w/o native Intel IDE driver and confirmed working SATA drive.

Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39829 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/kontron/ktqm77/cmos.layout 1 file changed, 5 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

-#404 4 r 0 unused +#404 3 r 0 unused

# coreboot config options: southbridge -408 1 e 1 nmi -409 2 e 7 power_on_after_fail -411 1 e 11 sata_mode +407 1 e 1 nmi +408 2 e 7 power_on_after_fail +410 2 e 11 sata_mode

# coreboot config options: additional mainboard options 412 4 e 10 systemp_type @@ -130,6 +130,7 @@ 10 4 LM75@9e 11 0 AHCI 11 1 Compatible +11 2 Legacy 12 0 32M 12 1 64M 12 2 96M

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

2:21 p.m.

New subject: Change in coreboot[master]: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39829 )

Change subject: mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode ......................................................................

Patch Set 11:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2362 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2361 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2360

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/39829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85f72a172bcbc4c8b4bfb7a2baed7c6739b2d9f8 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 15 Apr 2020 21:21:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1678

days inactive

1699

days old

coreboot-gerrit@coreboot.org

13 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Angel Pons (Code Review)
Felix Singer (Code Review)
Frans Hendriks (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)