Change in coreboot[master]: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
Since CB:37231, the vboot working data has been replaced with vboot workbuf, so corrrect the help text of option VBOOT_STARTS_IN_ROMSTAGE accordingly.
BRANCH=none BUG=chromium:1021452 TEST=none
Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/security/vboot/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38900/1
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index ea70e65..1f0fee7 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -114,8 +114,8 @@ depends on !VBOOT_STARTS_IN_BOOTBLOCK help Firmware verification happens during the end of romstage (after - memory initialization). This implies that vboot working data is - allocated in CBMEM. + memory initialization). This implies that vboot workbuf is allocated + in CBMEM.
config VBOOT_MOCK_SECDATA bool "Mock secdata for firmware verification"
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38900/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38900/1/src/security/vboot/Kconfig@... PS1, Line 117: vboot workbuf Probably want to add a "the" article in front. Also might want to change it to "work buffer" instead, for a longer-form English description. Both are used interchangeably throughout vboot code.
Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Joel Kitching,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38900
to look at the new patch set (#2).
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
Since CB:37231, the vboot working data has been replaced with vboot work buffer, so corrrect the help text of option VBOOT_STARTS_IN_ROMSTAGE accordingly.
BRANCH=none BUG=chromium:1021452 TEST=none
Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/security/vboot/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38900/2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38900/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38900/1/src/security/vboot/Kconfig@... PS1, Line 117: vboot workbuf
Probably want to add a "the" article in front. […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38900/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38900/2//COMMIT_MSG@9 PS2, Line 9: Since CB:37231, the vboot working data has been replaced with vboot work Please add at least the commit message summary to the commit reference.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig@... PS2, Line 118: allocated in CBMEM. nit: maybe say "in CBMEM from the start and doesn't need to be reserved in memlayout", because all work buffers end up in CBMEM at some point
Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Joel Kitching,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38900
to look at the new patch set (#3).
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
Since CB:37231 [1], the vboot working data has been replaced with vboot work buffer, so corrrect the help text of option VBOOT_STARTS_IN_ROMSTAGE accordingly.
[1] security/vboot: Remove struct vboot_working_data
BRANCH=none BUG=chromium:1021452 TEST=none
Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/security/vboot/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/38900/3
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38900/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38900/2//COMMIT_MSG@9 PS2, Line 9: Since CB:37231, the vboot working data has been replaced with vboot work
Please add at least the commit message summary to the commit reference.
Done
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38900/2/src/security/vboot/Kconfig@... PS2, Line 118: allocated in CBMEM.
nit: maybe say "in CBMEM from the start and doesn't need to be reserved in memlayout", because all w […]
Done
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38900 )
Change subject: security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE ......................................................................
security/vboot: Correct help text of VBOOT_STARTS_IN_ROMSTAGE
Since CB:37231 [1], the vboot working data has been replaced with vboot work buffer, so corrrect the help text of option VBOOT_STARTS_IN_ROMSTAGE accordingly.
[1] security/vboot: Remove struct vboot_working_data
BRANCH=none BUG=chromium:1021452 TEST=none
Change-Id: I80783274179ae7582bbb4c8f9d392895623badce Signed-off-by: Yu-Ping Wu yupingso@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38900 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Joel Kitching kitching@google.com --- M src/security/vboot/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Joel Kitching: Looks good to me, approved
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index 2863952..e366cc4 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -114,8 +114,8 @@ depends on !VBOOT_STARTS_IN_BOOTBLOCK help Firmware verification happens during the end of romstage (after - memory initialization). This implies that vboot working data is - allocated in CBMEM. + memory initialization). This implies that the vboot work buffer is + in CBMEM from the start and doesn't need to be reserved in memlayout.
config VBOOT_MOCK_SECDATA bool "Mock secdata for firmware verification"
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Yu-Ping Wu (Code Review)