Attention is currently required from: Martin Roth, Jonathan Zhang, Arthur Heymans.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50411 )
Change subject: security/intel/cbnt: Add option to generate BPM
......................................................................
Patch Set 33:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50411/comment/50adf399_8d67b300
PS3, Line 10: json
Please add the format of the JSON config file. […]
The generated template/working config json doesn't explain how to use it.
There are 66 values that needs to be documented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38808ca56953b80bac36bd186932d6286a79bebe
Gerrit-Change-Number: 50411
Gerrit-PatchSet: 33
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 29 Mar 2021 15:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment