Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86324?usp=email )
(
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/nissa/var/pujjoniru: Tune I2C_5 parameters ......................................................................
mb/google/nissa/var/pujjoniru: Tune I2C_5 parameters
1. Modify the I2C frequency of the touchpad to below 400 KHz to meet the spec. 2. Modify the Thd dat of DATA between 0.3 us and 0.9 us to meet the spec.
Before: I2C5 - 407KHz Thd - 0.06us
After: I2C5 - 387Khz Thd - 0.34us
BUG=b:391796230,b:391788680 TEST=Check that the wave form meets the spec.
Change-Id: I3c8c8d3b78236247ca7be810ac152085f615a6ef Signed-off-by: Hualin Wei weihualin@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/86324 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Qinghong Zeng zengqinghong@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/mainboard/google/brya/variants/pujjoniru/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Eric Lai: Looks good to me, approved Qinghong Zeng: Looks good to me, but someone else must approve build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/pujjoniru/overridetree.cb b/src/mainboard/google/brya/variants/pujjoniru/overridetree.cb index 02ab633..11098ac 100644 --- a/src/mainboard/google/brya/variants/pujjoniru/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjoniru/overridetree.cb @@ -82,9 +82,9 @@ .speed = I2C_SPEED_FAST, .speed_config[0] = { .speed = I2C_SPEED_FAST, - .scl_lcnt = 152, - .scl_hcnt = 79, - .sda_hold = 7, + .scl_lcnt = 150, + .scl_hcnt = 85, + .sda_hold = 35, } }, }"