Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45951 )
Change subject: soc/intel: deduplicate ACPI timer emulation
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/common/block...
File src/soc/intel/common/block/cpu/pm_timer_emulation.c:
https://review.coreboot.org/c/coreboot/+/45951/17/src/soc/intel/common/block...
PS17, Line 26: msr.lo = (EMULATE_DELAY_VALUE << EMULATE_DELAY_OFFSET_VALUE) |
Not all versions set this value, are we sure about it?
Furquan, could you have a look at your docs, please, if APL needs that or has that setting at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied4b312b6d53e80e71c55f4d1ca78a8cb2799793
Gerrit-Change-Number: 45951
Gerrit-PatchSet: 17
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 10:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment