build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40300 )
Change subject: mainboard: add Dell Latitude E7240 ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... File src/mainboard/dell/latitude_e7240/gpio.c:
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 14: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT | GPIO_IRQ_LEVEL, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 8 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 15: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_IRQ_LEVEL, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 9 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 19: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT | GPIO_IRQ_LEVEL, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 13 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 51: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT | GPIO_IRQ_LEVEL, .route = GPIO_ROUTE_SMI, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 45 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 53: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 47 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 58: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_IRQ_LEVEL, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 52 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 61: { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT, .pirq = GPIO_PIRQ_APIC_ROUTE }, /* 55 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/40300/2/src/mainboard/dell/latitude... PS2, Line 102: }; adding a line without newline at end of file
-
build bot (Jenkins) (Code Review)