Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35855 )
Change subject: asus/f2a85m_pro: Fix superio type in devicetree ......................................................................
asus/f2a85m_pro: Fix superio type in devicetree
The superio driver that was linked in is nct6779d but static devicetree expected symbol superio_nuvoton_nct5572d_ops.
Change-Id: I648b7680bb39b9ff5b38cc3bd5147bd336e0b282 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/35855/1
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index e261505..7637565 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -42,7 +42,7 @@ device pci 14.1 off end # unused device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x780e - chip superio/nuvoton/nct5572d + chip superio/nuvoton/nct6779d device pnp 2e.0 off end # FDC device pnp 2e.1 off end # LPT1 device pnp 2e.2 on # COM1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35855 )
Change subject: asus/f2a85m_pro: Fix superio type in devicetree ......................................................................
Patch Set 1: Code-Review+2
from the pin count on the rather bad picture of this board I found, it definitely isn't the nct5572d; since the nct6779d driver is linked in and the pin count seems to be right, I'd say that this is correct
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35855 )
Change subject: asus/f2a85m_pro: Fix superio type in devicetree ......................................................................
asus/f2a85m_pro: Fix superio type in devicetree
The superio driver that was linked in is nct6779d but static devicetree expected symbol superio_nuvoton_nct5572d_ops.
Change-Id: I648b7680bb39b9ff5b38cc3bd5147bd336e0b282 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35855 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index 238ab51..f13e3e8 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -54,7 +54,7 @@ device pci 14.1 off end # unused device pci 14.2 on end # HDA 0x4383 device pci 14.3 on # LPC 0x780e - chip superio/nuvoton/nct5572d + chip superio/nuvoton/nct6779d device pnp 2e.0 off end # FDC device pnp 2e.1 off end # LPT1 device pnp 2e.2 on # COM1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35855 )
Change subject: asus/f2a85m_pro: Fix superio type in devicetree ......................................................................
Patch Set 2:
Just a note, that this caused a regression [1]. Denis had already reported the regression in the board status repository, but was one commit off [2].
Reverting this commit here on top of master and, to fix the now caught build error, revert commit b2a10f8264 (devicetree: Remove weak declarations for ops), Ifb783e2f733d5c65c615e5c1879e3e4c7a83e049 [3], gets rid of the hang.
I’ll try to figure out, what is wrong with the Super I/O settings in the devicetree.
[1]: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/5GCRU... "Asus F2A85-M Pro: Accessing DMA1_RESET_REG in `isa_dma_init()` hangs system" [2]: https://review.coreboot.org/cgit/board-status.git/commit/asus/f2a85-m/4.10-9... [3]: https://review.coreboot.org/c/coreboot/+/35086
-
Felix Held (Code Review) -
Kyösti Mälkki (Code Review)
-
Paul Menzel (Code Review)