Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48583 )
Change subject: soc/intel: hook up new gpio device in the soc chips ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/48583/7/src/soc/intel/alderlake/chi... PS7, Line 202: else if (dev->path.type == DEVICE_PATH_GPIO) : dev->ops = &soc_gpio_ops;
Rather than adding this to every SoC, I think this can be handled within soc/intel/common/block/gpio […]
Ah thanks, that could indeed work - I tried this before but wasn't sure how we get the ops assigned to the right device then. However, I'm unsure if `assert` is a good thing here. Wouldn't that halt the machine on the first device if "halt on assertion fail" is selected? What about a simple `if`?
-
Michael Niewöhner (Code Review)