Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30866
Change subject: /src/mb/google/poppy/variants/atlas: Revise SPK reset ......................................................................
/src/mb/google/poppy/variants/atlas: Revise SPK reset
This patch revises the pad reset config of speaker reset GPIO pin from RSMRST to PLTRST. Audio engineer suggested to reset the amps with warm reset.
BUG=b:122441567 BRANCH=None TEST=warm & cold reset & suspend_stress_test -c 10 and ensure the speakers are working well.
Change-Id: I87c554b186b068da93e1662a97afaf01dddae0ef Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/30866/1
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 02c145c..c8203df 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -275,7 +275,7 @@ /* F10 : I2C5_SDA ==> HP_IRQ_GPIO */ PAD_CFG_GPI_APIC(GPP_F10, 20K_PU, PLTRST), /* F11 : I2C5_SCL ==> SPKR_RST_L */ - PAD_CFG_GPO(GPP_F11, 1, RSMRST), + PAD_CFG_GPO(GPP_F11, 1, PLTRST), /* F12 : EMMC_CMD */ PAD_CFG_NF(GPP_F12, NONE, DEEP, NF1), /* F13 : EMMC_DATA0 */
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30866 )
Change subject: /src/mb/google/poppy/variants/atlas: Revise SPK reset ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30866 )
Change subject: /src/mb/google/poppy/variants/atlas: Revise SPK reset ......................................................................
/src/mb/google/poppy/variants/atlas: Revise SPK reset
This patch revises the pad reset config of speaker reset GPIO pin from RSMRST to PLTRST. Audio engineer suggested to reset the amps with warm reset.
BUG=b:122441567 BRANCH=None TEST=warm & cold reset & suspend_stress_test -c 10 and ensure the speakers are working well.
Change-Id: I87c554b186b068da93e1662a97afaf01dddae0ef Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com Reviewed-on: https://review.coreboot.org/c/30866 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/poppy/variants/atlas/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c index 4de65d4..5a76d83 100644 --- a/src/mainboard/google/poppy/variants/atlas/gpio.c +++ b/src/mainboard/google/poppy/variants/atlas/gpio.c @@ -275,7 +275,7 @@ /* F10 : I2C5_SDA ==> HP_IRQ_GPIO */ PAD_CFG_GPI_APIC(GPP_F10, 20K_PU, PLTRST), /* F11 : I2C5_SCL ==> SPKR_RST_L */ - PAD_CFG_GPO(GPP_F11, 1, RSMRST), + PAD_CFG_GPO(GPP_F11, 1, PLTRST), /* F12 : EMMC_CMD */ PAD_CFG_NF(GPP_F12, NONE, DEEP, NF1), /* F13 : EMMC_DATA0 */
-
Duncan Laurie (Code Review) -
Gaggery Tsai (Code Review)
-
Patrick Georgi (Code Review)