Attention is currently required from: Andrey Petrov, Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Ronak Kanabar, Tarun.
Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82699?usp=email )
Change subject: soc/intel/meteorlake: Exclude deprecated upd from FSP2.4 builds
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82699/comment/415fedd1_4b88ce1a?usp... :
PS3, Line 9: EnableMultiPhaseSiliconInit upd is deprecated and has been
: removed starting with v2.4 of FSP specification.
are you saying `EnableMultiPhaseSiliconInit` UPD has deprecated because it has been set to 1? (w/ FSP 2.4 spec)
have you captured that in FSP spec
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/82699/comment/19f31283_767f7969?usp... :
PS3, Line 80: #if (CONFIG(FSPS_HAS_ARCH_UPD) && !CONFIG(PLATFORM_USES_FSP2_4))
why are we disabling `EnableMultiPhaseSiliconInit` for FSP 2.4 specification?
ideally EnableMultiPhaseSiliconInit is viable since sometime FSP 2.1 spec onwards ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82699?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icdbf3bacc0a05975fc941b264fd400d74f506fce
Gerrit-Change-Number: 82699
Gerrit-PatchSet: 3
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 30 May 2024 09:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No