Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/7116 )
Change subject: Poor man's ftrace from akaros
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
Cute for not much code it looks pretty handy in times of need! Just a few minor comments.
https://review.coreboot.org/c/coreboot/+/7116/7/src/console/printk.c
File src/console/printk.c:
https://review.coreboot.org/c/coreboot/+/7116/7/src/console/printk.c@116
PS7, Line 116: in
should this be static unsigned?
https://review.coreboot.org/c/coreboot/+/7116/7/src/console/printk.c@133
PS7, Line 133: tab_depth--;
maybe bound this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/7116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69c3c20d30ebd666c0e859cea906a3fd5a094441
Gerrit-Change-Number: 7116
Gerrit-PatchSet: 7
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
edward.ocallaghan@koparo.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rudolf Marek
r.marek@assembler.cz
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 May 2020 03:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment