Attention is currently required from: Raul Rangel, Tim Wawrzynczak, Karthik Ramasubramanian. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63211 )
Change subject: drivers/i2c/generic: Add support for i2c device detection ......................................................................
Patch Set 3:
(1 comment)
File src/drivers/i2c/generic/chip.h:
https://review.coreboot.org/c/coreboot/+/63211/comment/59f86c2a_0965efbe PS2, Line 32: probed
Should we instead convert this into an enum? I imagine having `probed` and `detect` set is incorrect […]
I'm not sure if it's incorrect, but certainly redundant. 'probed' is a dirty kernel hack since coreboot generates an incorrect ACPI status for these i2c devices which are not present. Ideally we'd replace all instances of 'probed' with 'detect' tree-wide once we're able to confirm that runtime detection works. So far, I've implemented this on octopus, reef, hatch, and poppy. I believe Tim tested it on a Brya variant as well.
-
Matt DeVillier (Code Review)