Change in coreboot[master]: src/mainboard: Add Star Labs labtop series

[Andy Pont (Code Review)]

Attention is currently required from: Sean Rhodes.
Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55128 )

Change subject: src/mainboard: Add Star Labs labtop series
......................................................................

Patch Set 15:

(3 comments)

File src/mainboard/starlabs/labtop/mainboard.c:

https://review.coreboot.org/c/coreboot/+/55128/comment/1d4b3640_97d7391a 
PS15, Line 33: #if CONFIG(BOARD_STARLABS_LABTOP_CML)
> How?

if (CONFIG(BOARD_STARLABS_LABTOP_CML))
    return "L4";
else
    return "L3-U";

https://review.coreboot.org/c/coreboot/+/55128/comment/4d78cb3d_15bae972 
PS15, Line 52: /* Override smbios_mainboard_board_type */
             : smbios_board_type smbios_mainboard_board_type(void)
             : {
             : 	return SMBIOS_BOARD_TYPE_MOTHERBOARD;
             : }
> Why?

When this file was originally created this function returned SMBIOS_BOARD_TYPE_UNKNOWN. As of commit d37cfb7 it was changed to SMBIOS_BOARD_TYPE_MOTHERBOARD and no longer needs to be overridden.

File src/mainboard/starlabs/labtop/variants/kbl/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/55128/comment/1a10a42a_6b5c118f 
PS15, Line 24: .up_delay_ms= 200,// T3
             : 		.down_delay_ms= 0,// T10
             : 		.cycle_delay_ms = 500,// T12
             : 		.backlight_on_delay_ms=50,// T7
             : 		.backlight_off_delay_ms = 0,// T9
             : 		.backlight_pwm_hz = 200,
> As far as I know, nit is an achaic term for brightness of a display. […]

Short for "nit-pick"!

Have a look at src/mainboard/51nb/x210/devicetree.cb all the equals signs and hence the comments are aligned.