Change in coreboot[master]: sb/intel/i82801gx: Use symbolic name for register, code rework
Petr Cvek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35737 )
Change subject: sb/intel/i82801gx: Use symbolic name for register, code rework ......................................................................
Patch Set 3:
(5 comments)
I've had to fix missing parameters for res2mmio in the new version of the patch.
https://review.coreboot.org/c/coreboot/+/35737/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35737/2//COMMIT_MSG@7 PS2, Line 7: Correctly align register offset
Ack
Done
https://review.coreboot.org/c/coreboot/+/35737/2//COMMIT_MSG@10 PS2, Line 10:
Ack
Done
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280... File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280... PS2, Line 97: u32
Ack
Done
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280... PS2, Line 158: ahci_
Ack
Done
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280... PS2, Line 158: 0x24
if a generic name PCI_BASE_ADDRESS_5 is OK, I'm gonna change the rest of reg 0x24 references in th […]
Done
-
Petr Cvek (Code Review)