Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Vidya Gopalakrishnan, Tyler Wang, Eric Lai, Peter Ou.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71860 )
Change subject: mb/google/nissa/var/craask: Modify DPTF settings
......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71860/comment/02e43388_2c449379
PS2, Line 112: register "power_limits_config[ADL_N_041_6W_CORE]" = "{
: .tdp_pl1_override = 6,
: .tdp_pl2_override = 25,
: .tdp_pl4 = 78,
: }"
:
: register "power_limits_config[ADL_N_021_6W_CORE]" = "{
: .tdp_pl1_override = 6,
: .tdp_pl2_override = 25,
: .tdp_pl4 = 78,
: }"
:
These are now the same as the defaults in src/soc/intel/alderlake/chipset.cb, so I think we can remove them (in a separate CL).
https://review.coreboot.org/c/coreboot/+/71860/comment/d400f02f_75262769
PS2, Line 124: register "power_limits_config[ADL_N_081_15W_CORE]" = "{
: .tdp_pl1_override = 15,
: .tdp_pl2_override = 35,
: .tdp_pl4 = 83,
: }"
:
These are the same as the defaults in src/soc/intel/alderlake/chipset.cb, so I don't think overriding them here makes any difference?
https://review.coreboot.org/c/coreboot/+/71860/comment/b5d49e25_b1e7e8fb
PS2, Line 156: pl1
Don't you need to change the pl1 / pl2 settings for 15W too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I325704d6fc4ddaf56eaddd6a69bc619588df99cd
Gerrit-Change-Number: 71860
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Jan 2023 00:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment